Add new module data transformation software #300#314
Conversation
Ludee
added
priority: critical 🔥
jh-RLI
left a comment
jh-RLI
left a comment
There was a problem hiding this comment.
Whilst comparing the changes with ERSmeta, a few things struck me
| "type": "object", | ||
| "properties": { | ||
| "moduleDataTransformationSoftware": { | ||
| "description": "An Object that describes the instruments used in the measurement.", |
There was a problem hiding this comment.
Is instrument the correct word here ? should it be software?
There was a problem hiding this comment.
In general .... maybe i overlooked but isnt there a SoftwareDescription property missing?
| "items": { | ||
| "type": "object", | ||
| "properties": { | ||
| "softwareName": { |
There was a problem hiding this comment.
In ERSmeta the software name ha a 1:1 Card. it should be required here. (Required if module is used)
There was a problem hiding this comment.
All entries of all new modules are new and should be optional. We can add this later if needed.
| "badge": "Module", | ||
| "title": "Software Path" | ||
| }, | ||
| "softwareVersion": { |
There was a problem hiding this comment.
Same here in ERS meta this is a 1:1 card. -> should be required
| "badge": "Module", | ||
| "title": "Software Version" | ||
| }, | ||
| "softwareType": { |
There was a problem hiding this comment.
Also required in ERSMeta 1..* card.
| "badge": "Module", | ||
| "title": "Software Type (ERSmeta)" | ||
| }, | ||
| "programmingLanguage": { |
There was a problem hiding this comment.
Also required in ERSMeta 1...* card.
2 participants
Summary of the discussion
Include the required fields from ERSMeta @sferenz
Type of change (CHANGELOG.md)
Added
Data Transformation Softwarefor dataset (#314)Workflow checklist
Automation
Closes #300
PR-Assignee
Reviewer