-
Notifications
You must be signed in to change notification settings - Fork 10
chore(deps)(deps-dev): bump happy-dom from 20.8.9 to 20.10.6 #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/npm_and_yarn/happy-dom-20.10.6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+267
−81
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Issue: The happy-dom bump lacks validation evidence
What's wrong
This PR changes the DOM implementation used by Vitest for node-ui, but the diff adds no test and the provided review notes say no tests were run. Because happy-dom is the runtime substrate for UI tests, a minor bump can change observable DOM behavior and also the trustworthiness of existing tests.
Example
A node-ui component test that relies on happy-dom behavior for events, layout-related DOM APIs, or resource loading could start passing or failing differently after this bump; without at least running the node-ui Vitest suite, the PR does not show that the test environment still exercises the app the same way.
Suggested direction
Add evidence from the relevant package test run, or add a focused regression test if this dependency bump is intended to fix a specific DOM behavior.
Confidence note
The provided notes say only the unified diff was reviewed and no tests were run, so this is based on missing validation evidence rather than a locally reproduced failure.
For Agents
Look at packages/node-ui test scripts and CI config. Run the relevant node-ui test suite, preferably with coverage if that is the normal gate, and record the command/result in the PR. If the bump targets a specific happy-dom fix, add or point to a regression test that fails on 20.8.9 and passes on 20.10.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Issue: The happy-dom upgrade lacks package-level test validation
What's wrong
This PR changes the DOM implementation used by a large set of node-ui Vitest tests, but the diff adds no test changes and the provided verification notes say no tests were run. Without at least the existing node-ui suite passing under the new happy-dom version, the PR has no evidence that the changed test/runtime behavior is compatible.
Example
A regression in happy-dom event dispatch, form handling, timers, or DOM parsing could make existing component tests fail or pass differently after this bump. The expected validation would be something like
pnpm --filter @origintrail-official/dkg-node-ui testpassing with happy-dom 20.10.6.Suggested direction
Run and report the node-ui Vitest suite for this dependency update; if the upgrade is meant to fix a specific DOM behavior, include a focused test that would fail on 20.8.9 and pass on 20.10.6.
For Agents
Look at
packages/node-ui/package.jsonand the node-ui Vitest suite. Preserve the dependency bump, but add CI/PR evidence thatpnpm --filter @origintrail-official/dkg-node-ui testwas run against the updated lockfile, or add/adjust a focused regression test only if the bump targets a specific happy-dom behavior.