-
Notifications
You must be signed in to change notification settings - Fork 43
Fix: Implemented Commit Message Linting and Automation for Identity-API Issue#85 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mohan-bee
wants to merge
20
commits into
PSMRI:develop
Choose a base branch
from
mohan-bee:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
6769906
Bad commit
mohan-bee c2729a5
bad commit
mohan-bee b55bf9a
Hello
mohan-bee 9e65b0f
Some random message
mohan-bee c3b745b
Some random message
mohan-bee 87e067e
fix: changes
mohan-bee c82fce9
fix: github overflow files fix
mohan-bee 885b239
fix: git log fix
mohan-bee 17feb1f
fix: eS Modules
mohan-bee 8fe14be
fix: eS Modules
mohan-bee 53e7d77
fix: eS Modules
mohan-bee 768bc16
fix: changes
mohan-bee ebc961f
fix: latest Commit
mohan-bee 83e15e5
fix: latest Commit
mohan-bee ae82f03
Merge pull request #7 from mohan-bee/test
mohan-bee 1afa5e4
fix: test-a
mohan-bee 17922c8
fix: eS Modules
mohan-bee 948f7ec
fix: done with this Issue with issue id #85
mohan-bee 45da1cc
Merge pull request #9 from mohan-bee/test
mohan-bee d44f361
fix: version update
mohan-bee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Commit Lint | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, edited] | ||
|
|
||
| jobs: | ||
| lint-commits: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: "18" | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Lint commit messages | ||
| uses: wagoid/commitlint-github-action@v4 | ||
| with: | ||
| configFile: ./commitlint.config.cjs | ||
| failOnWarnings: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ logs/ | |
| .settings | ||
| .springBeans | ||
| .sts4-cache | ||
| node_modules/ | ||
|
|
||
| ### IntelliJ IDEA ### | ||
| .idea | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| npx --no -- commitlint --edit "$1" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| const config = require('@commitlint/config-conventional'); | ||
|
|
||
| module.exports = { | ||
| ...config, | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure Husky hook script includes the proper header
The hook currently only runs the lint command but is missing the shebang and Husky loader. Without these, it may not execute correctly. Please apply:
📝 Committable suggestion