config: reject names containing slashes#2272
Open
ousamabenyounes wants to merge 1 commit into
Open
Conversation
omar-polo
reviewed
Jul 21, 2026
omar-polo
left a comment
Contributor
There was a problem hiding this comment.
Hello,
thanks for the fix! to be 100% clear, I think the PR is slightly more complex than what is needed, but it definitely fixes the issue and adds a test even, which is very appreciated! I'll merged it as-is and fixup a style nit as a follow-up.
omar-polo
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reject configuration names containing
/when adding a store, source, or destination configuration.This prevents commands like
plakar destination add s3://xxxx access_key=yyyfrom silently creating a destination nameds3://xxxxinstead of reporting the missing name.Closes #2102
Test verification (RED -> GREEN)
RED on
origin/mainplus the new test, in Docker (golang:1.25):GREEN after the fix, same targeted Docker test:
Package validation:
Full validation note
Docker
go build -v ./...completed successfully. Dockergo test ./...then failed insubcommands/pkgwith a Pebble closed-cache panic inTestPkgCreateExecuteFailsOnBadConnector:I checked that failure against clean
origin/main; the same test also fails there in the same Docker non-root environment: