chore(code): upgrade Electron 42, React 19.2, Vite 7 and deps#2817
chore(code): upgrade Electron 42, React 19.2, Vite 7 and deps#2817charlesvien wants to merge 1 commit into
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
There was a problem hiding this comment.
Gates denied this PR: it touches dependencies and toolchain (Electron, React, Vite major version bumps) which are on the deny-list, and it exceeds the size ceiling at 6791 lines across a lockfile and multiple package.json files. Dependency/toolchain upgrades of this scale require human review.
|
Reviews (1): Last reviewed commit: "upgrade electron 42, react 19.2, vite 7 ..." | Re-trigger Greptile |
1bd1c12 to
e3f5c9c
Compare
f934def to
3b3c512
Compare
507c6ab to
d1b0efd
Compare
3b3c512 to
05dc196
Compare
d1b0efd to
8e56223
Compare
05dc196 to
8456ef4
Compare
There was a problem hiding this comment.
Gates denied this PR: it touches dependencies and toolchain (Electron, React, Vite major version bumps) which are on the deny-list, and it exceeds the size ceiling at 6791 lines across a lockfile and multiple package.json files. Dependency/toolchain upgrades of this scale require human review.
8456ef4 to
6cdb962
Compare
8e56223 to
5a35c1d
Compare
6cdb962 to
ae7bae2
Compare
5a35c1d to
3619a50
Compare
ae7bae2 to
96ed56f
Compare
3619a50 to
a79ecab
Compare

Problem
We had fallen several majors behind on core dependencies (Electron 41, React 19.1, Vite 6) plus a long tail of libraries, missing performance, security and bug fixes. A previous attempt (#2512) predated the electron-builder and electron-vite migration and was closed, so this redoes the upgrade from first principles on top of that work.
Changes
Dependency modernization across the monorepo:
node-abi: ^3.92.0override is added (older node-abi can't resolve Electron 42's ABI).@types/reactand@types/react-domare deduped to one copy (a second copy made nominally distinctReftypes and broke shared UI ref props).@vitejs/plugin-reacton the Vite 7 line). Not Vite 8 or Rolldown: electron-vite 4 supportsvite ^5 || ^6 || ^7, so 7 is the ceiling.zod@^4.0.0override) so cross-package schema types stay nameable.setQueryDatacall sites inuseSignalTeamConfigMutationsanduseTaskMutations(a typed optimistic value and an explicit updater generic).Stacked on #2811 (electron-vite migration); review against
refactor/electron-vite.How did you test this?
Locally on macOS arm64:
pnpm installresolves cleanly and rebuilds better-sqlite3 against Electron 42.4.0 with no patch.pnpm typecheck(22 of 22 packages),pnpm lintandpnpm buildall pass.pnpm testpasses (@posthog/core1615 tests and the rest).@posthog/gitand@posthog/agentpass in isolation; they only flaked under concurrent build-plus-test load (a 15s git-ops timeout), not on their own.The standard PR checks (typecheck, build, unit tests) run on this PR. The full signed and notarized multi-platform packaging, with the Electron 42 native rebuild and smoke test, runs via the build workflow on
refactor/electron-viteonce this lands there.Automatic notifications