Skip to content

fix(shell): Take a bigger margin for terminal size#2811

Merged
RemiBonnet merged 1 commit into
stagingfrom
erebe/shell
Jul 13, 2026
Merged

fix(shell): Take a bigger margin for terminal size#2811
RemiBonnet merged 1 commit into
stagingfrom
erebe/shell

Conversation

@erebe

@erebe erebe commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

When openning the shell websocket, the frontend compute the width and height of the terminal to forward it to the backend.
Today, the width and height are too big causing line wrapping

  • Use the shell container size instead of the global one
  • increase the cell height to avoid line wrapping

Before
image

After
image

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.20%. Comparing base (87e33c3) to head (98ea0c0).

Files with missing lines Patch % Lines
...use-terminal-dimensions/use-terminal-dimensions.ts 75.00% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2811      +/-   ##
===========================================
- Coverage    47.60%   47.20%   -0.40%     
===========================================
  Files          783     1176     +393     
  Lines        19626    25445    +5819     
  Branches      5954     7546    +1592     
===========================================
+ Hits          9342    12011    +2669     
- Misses        8635    11395    +2760     
- Partials      1649     2039     +390     
Flag Coverage Δ
unittests 47.20% <76.47%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread libs/shared/util-hooks/src/lib/use-terminal-dimensions/use-terminal-dimensions.ts Outdated
When openning the shell websocket, the frontend compute the width and height of the terminal to forward it to the backend.
Today, the width and height are too big causing line wrapping

    Use the shell container size instead of the global one
    increase the cell height to avoid line wrapping
@RemiBonnet RemiBonnet self-requested a review July 13, 2026 08:44
@RemiBonnet RemiBonnet merged commit ff1fdd9 into staging Jul 13, 2026
12 checks passed
@RemiBonnet RemiBonnet deleted the erebe/shell branch July 13, 2026 08:48
@RemiBonnet

Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.327.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants