fix(service-logs): normalize identical date range#2813
Closed
RemiBonnet wants to merge 1 commit into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2813 +/- ##
===========================================
- Coverage 47.20% 47.04% -0.16%
===========================================
Files 1176 35 -1141
Lines 25445 1288 -24157
Branches 7546 427 -7119
===========================================
- Hits 12011 606 -11405
+ Misses 11395 560 -10835
+ Partials 2039 122 -1917
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Superseded by #2814 using the requested branch name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
startDateandendDatevalues into a one-hour range.Why
Alert links can only interpolate timestamps, so they may generate service-log URLs where
startDate === endDate. Those values were passed unchanged to Loki, producing a zero-length query range and no useful logs.Validation
yarn jest --config libs/domains/service-logs/feature/jest.config.ts libs/domains/service-logs/feature/src/lib/hooks/use-service-history-logs/normalize-service-history-date-range.spec.ts --runInBand(4 tests passed)git diff --checkEnvironment note
The Nx project target could not start its plugin worker in the isolated worktree, so the focused Jest, ESLint, and Prettier commands were run directly.