Skip to content

Table 14.2.1 - #93

Open
DmitryMK wants to merge 7 commits into
mainfrom
19-table-14-2-1
Open

Table 14.2.1#93
DmitryMK wants to merge 7 commits into
mainfrom
19-table-14-2-1

Conversation

@DmitryMK

@DmitryMK DmitryMK commented May 4, 2026

Copy link
Copy Markdown
Collaborator

There are differences from the CSR table:

  1. There is no separate column with the category label, it is combined with statistics label into 1 column. As I understand this is standard gtsummary structure.
  2. Categories have their own labels (versus none in the CSR).
  3. Split on pages to avoid one category being summarized on different pages.

There are few derivations, which we might want to move to ADSL.

@DmitryMK DmitryMK linked an issue May 4, 2026 that may be closed by this pull request
@github-actions

Copy link
Copy Markdown

⚠️ Styler – Formatting Issues Found

The following 2 file(s) in code/ are not consistently formatted. Please run styler::style_dir("code") locally and commit the result.

📂 2 file(s) need formatting – click to expand
  • tables/t_14_2_1.r
  • utils/table_functions.r

Run locally to reproduce or fix:

# Install styler if needed
install.packages("styler")

# Check which files need formatting (dry run – no files are changed)
library(styler)
styler::style_dir("code", dry = "on")

# Apply formatting to all files
styler::style_dir("code")

After running style_dir, review the changes with git diff, then commit and push.

@github-actions

Copy link
Copy Markdown

✅ Lintr – No Issues Found

All R files in code/ passed linting with no findings. 🎉


Run locally:

# Install lintr if needed
install.packages("lintr")

# Run lintr on the code directory (uses .lintr config at repo root)
library(lintr)
lintr::lint_dir("code")

@github-actions

Copy link
Copy Markdown

⚠️ Spelling – Issues Found

The following potential misspellings were detected in code/. Please review and fix them before merging.

🔍 26 finding(s) – click to expand
  • agegr — found in: t_14_2_1.r:52,72,96
  • BMI — found in: t_14_2_1.r:49,105,106
  • bmibl — found in: t_14_2_1.r:73,105
  • bmiblgr — found in: t_14_2_1.r:54,73,106
  • chisq — found in: t_14_2_1.r:118
  • CRF — found in: adsl.r:153
  • durdis — found in: t_14_2_1.r:73,100
  • durdsgr — found in: t_14_2_1.r:73,101
  • educlvl — found in: t_14_2_1.r:73,102,187
  • fct — found in: t_14_2_1.r:51,52,53
  • fmt — found in: table_functions.r:9,19,20
  • forcats — found in: t_14_2_1.r:20
  • heightbl — found in: t_14_2_1.r:73,104,187
  • MMSE — found in: t_14_2_1.r:99
  • nonmiss — found in: t_14_2_1.r:83
  • oneway — found in: t_14_2_1.r:113,117
  • pn — found in: t_14_2_1.r:51
  • pvalue — found in: t_14_2_1.r:115
  • racec — found in: t_14_2_1.r:53,72,98
  • RACEC — found in: adsl.r:155,163
  • racecn — found in: t_14_2_1.r:53
  • RACECN — found in: adsl.r:163
  • reframe — found in: t_14_2_1.r:138
  • sd — found in: t_14_2_1.r:83
  • vairable — found in: t_14_2_1.r:49
  • weightbl — found in: t_14_2_1.r:73,103

Run locally to reproduce:

# Install spelling if needed
install.packages("spelling")

# Run spell check on the code directory (uses inst/WORDLIST for domain terms)
library(spelling)
r_files <- list.files("code", recursive = TRUE, full.names = TRUE, pattern = "\\.[rR]$")
ignore  <- readLines("inst/WORDLIST")
spelling::spell_check_files(r_files, ignore = ignore, lang = "en-US")

Add legitimate domain-specific terms (clinical acronyms, variable names) to inst/WORDLIST (one word per line) to suppress false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Table 14.2.1

1 participant