Archive schools#908
Draft
zetter-rpf wants to merge 4 commits into
Draft
Conversation
Many school owners contact us because they have created a school that is not being used. Because they are an owner/teacher on this school it prevents them from joining a new school. Add the ability for admins to archive a school. I considered using the existing rejected_at flag but this was modellling a different that we want to keep historical data for. Instead I'll add a 'hidden?' method to group this behaviour together.
When we are manually doing this we tend to delete all the roles for the school. This isn't ideal as it's hard to recover from or later use that data in the datawarehouse or sync to salesforce. Instead add an 'archived_at' column that we can use to keep the data around. I think this is a good use of a default scope - it would be dangerous if we were allowing archived roles to access data so it's safer to block them. I've chosen not to archive students as we already have a deletion process for them that the owner can do before requesting the school to be removed. Also, most of the requests for deletions are duplicate schools that have no students.
Test coverage92.09% line coverage reported by SimpleCov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Points for consideration:
What's changed?
Description of what's been done - bullets are often best
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, a migration, or upgrading a Gem. That kind of thing.