You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
mac_edge config sets a move key that already includes the package directory name, but
pkg_archive.bzl also prefixes every move key with pkg_name, resulting in a doubled path like
MicrosoftEdge-...pkg/MicrosoftEdge-...pkg/.... This can cause the external repository fetch to
fail on macOS when mv cannot find the source path, breaking all pinned mac Edge consumers.
pkg_archive expands the downloaded pkg into a directory named pkg_name and then prefixes every
move source with pkg_name + "/" + key; however, mac_edge’s move key already begins with the same
pkg_name, producing a duplicated path for the mv command.
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution
## Issue description
`pkg_archive` derives `pkg_name` from the URL filename and then runs `mv pkg_name + "/" + key`. The generated `mac_edge` `move` key already starts with the same `pkg_name`, so the effective source path becomes double-prefixed and may not exist.
## Issue Context
This file is auto-generated via `bazel run scripts:pinned_browsers`, so the generator should be updated too to avoid reintroducing the bug.
## Fix Focus Areas
- common/repositories.bzl[124-131]
- scripts/pinned_browsers.py[283-305]
- common/private/pkg_archive.bzl[20-55]
## Recommended fix
- Change the `move` key for `mac_edge` to be relative to the expanded directory (e.g. `"Payload/Microsoft Edge.app"`), and update `scripts/pinned_browsers.py:mac_edge_browser_content` to generate that relative key.
- (Alternative) Make `pkg_archive.bzl` tolerant by not prefixing when `key` already begins with `pkg_name + "/"`.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
The workflow job CI Success failed because it intentionally exited with status code 1 after detecting that one or more required jobs failed. - The step runs if true; then echo "One or more required jobs failed"; exit 1; fi, which guarantees failure and indicates upstream required jobs did not succeed. - No specific failing test is shown in this log; the actual failure is in another required job whose logs are not included here.
Relevant error logs:
1: ##[group]Runner Image Provisioner2: Hosted Compute Agent
...
14: Image: ubuntu-24.0415: Version: 20260622.220.116: Included Software: https://github.com/actions/runner-images/blob/ubuntu24/20260622.220/images/ubuntu/Ubuntu2404-Readme.md17: Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20260622.22018: ##[endgroup]19: ##[group]GITHUB_TOKEN Permissions20: Contents: read21: Metadata: read22: ##[endgroup]23: Secret source: Actions24: Prepare workflow directory25: Prepare all required actions26: Complete job name: CI Success27: ##[group]Run if true; then28: �[36;1mif true; then�[0m29: �[36;1m echo "One or more required jobs failed"�[0m30: �[36;1m exit 1�[0m31: �[36;1mfi�[0m32: shell: /usr/bin/bash -e {0}33: ##[endgroup]34: One or more required jobs failed35: ##[error]Process completed with exit code 1.36: Cleaning up orphan processes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B-buildIncludes scripting, bazel and CI integrations
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to update pinned browsers and drivers
Merge after verifying the new browser versions are properly passing the tests