Skip to content

[build] Automated Browser Version Update#17721

Merged
diemol merged 1 commit into
trunkfrom
pinned-browser-updates
Jun 29, 2026
Merged

[build] Automated Browser Version Update#17721
diemol merged 1 commit into
trunkfrom
pinned-browser-updates

Conversation

@selenium-ci

Copy link
Copy Markdown
Member

This is an automated pull request to update pinned browsers and drivers

Merge after verifying the new browser versions are properly passing the tests

@selenium-ci selenium-ci added the B-build Includes scripting, bazel and CI integrations label Jun 27, 2026
@qodo-code-review

Copy link
Copy Markdown
Contributor

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Context used
✅ Compliance rules (platform): 11 rules

Grey Divider


Action required

1. Edge pkg move path 🐞 Bug ≡ Correctness
Description
mac_edge config sets a move key that already includes the package directory name, but
pkg_archive.bzl also prefixes every move key with pkg_name, resulting in a doubled path like
MicrosoftEdge-...pkg/MicrosoftEdge-...pkg/.... This can cause the external repository fetch to
fail on macOS when mv cannot find the source path, breaking all pinned mac Edge consumers.
Code

common/repositories.bzl[R124-130]

    pkg_archive(
        name = "mac_edge",
-        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/629dfc42-1f5f-46e4-a79c-7551f4f8bdee/MicrosoftEdge-149.0.4022.96.pkg",
-        sha256 = "405f68834a4de58f297c5993825c2ada9865639626cb0bfed809f10f98463d78",
+        url = "https://msedge.sf.dl.delivery.mp.microsoft.com/filestreamingservice/files/351963e1-f6ca-4391-a0a5-fb84132a0d98/MicrosoftEdge-149.0.4022.98.pkg",
+        sha256 = "0165f110a529d2ed8ce98ed82ef4b19c39ae6b0485b88ccd5797e710f6b9b9d5",
        move = {
-            "MicrosoftEdge-149.0.4022.96.pkg/Payload/Microsoft Edge.app": "Edge.app",
+            "MicrosoftEdge-149.0.4022.98.pkg/Payload/Microsoft Edge.app": "Edge.app",
        },
Evidence
pkg_archive expands the downloaded pkg into a directory named pkg_name and then prefixes every
move source with pkg_name + "/" + key; however, mac_edge’s move key already begins with the same
pkg_name, producing a duplicated path for the mv command.

common/private/pkg_archive.bzl[20-55]
common/repositories.bzl[124-131]
scripts/pinned_browsers.py[283-305]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`pkg_archive` derives `pkg_name` from the URL filename and then runs `mv pkg_name + "/" + key`. The generated `mac_edge` `move` key already starts with the same `pkg_name`, so the effective source path becomes double-prefixed and may not exist.

## Issue Context
This file is auto-generated via `bazel run scripts:pinned_browsers`, so the generator should be updated too to avoid reintroducing the bug.

## Fix Focus Areas
- common/repositories.bzl[124-131]
- scripts/pinned_browsers.py[283-305]
- common/private/pkg_archive.bzl[20-55]

## Recommended fix
- Change the `move` key for `mac_edge` to be relative to the expanded directory (e.g. `"Payload/Microsoft Edge.app"`), and update `scripts/pinned_browsers.py:mac_edge_browser_content` to generate that relative key.
- (Alternative) Make `pkg_archive.bzl` tolerant by not prefixing when `key` already begins with `pkg_name + "/"`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

Comment thread common/repositories.bzl
@qodo-code-review

Copy link
Copy Markdown
Contributor

CI Feedback 🧐

A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

Action: CI Success

Failed stage: Verify required jobs succeeded [❌]

Failed test name: ""

Failure summary:

The workflow job CI Success failed because it intentionally exited with status code 1 after
detecting that one or more required jobs failed.
- The step runs if true; then echo "One or more
required jobs failed"; exit 1; fi, which guarantees failure and indicates upstream required jobs did
not succeed.
- No specific failing test is shown in this log; the actual failure is in another
required job whose logs are not included here.

Relevant error logs:
1:  ##[group]Runner Image Provisioner
2:  Hosted Compute Agent
...

14:  Image: ubuntu-24.04
15:  Version: 20260622.220.1
16:  Included Software: https://github.com/actions/runner-images/blob/ubuntu24/20260622.220/images/ubuntu/Ubuntu2404-Readme.md
17:  Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu24%2F20260622.220
18:  ##[endgroup]
19:  ##[group]GITHUB_TOKEN Permissions
20:  Contents: read
21:  Metadata: read
22:  ##[endgroup]
23:  Secret source: Actions
24:  Prepare workflow directory
25:  Prepare all required actions
26:  Complete job name: CI Success
27:  ##[group]Run if true; then
28:  �[36;1mif true; then�[0m
29:  �[36;1m  echo "One or more required jobs failed"�[0m
30:  �[36;1m  exit 1�[0m
31:  �[36;1mfi�[0m
32:  shell: /usr/bin/bash -e {0}
33:  ##[endgroup]
34:  One or more required jobs failed
35:  ##[error]Process completed with exit code 1.
36:  Cleaning up orphan processes

@selenium-ci selenium-ci force-pushed the pinned-browser-updates branch from d84cbd5 to a4c15f0 Compare June 29, 2026 01:22
@diemol diemol merged commit ffb4528 into trunk Jun 29, 2026
108 of 110 checks passed
@diemol diemol deleted the pinned-browser-updates branch June 29, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B-build Includes scripting, bazel and CI integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants