Skip to content

Security fixes #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gquere wants to merge 3 commits into
base: V3
Choose a base branch
from
Open

Security fixes #23

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d30b1f8
prevent bash injection by quoting test var
Dec 11, 2025
101f1a6
set umask prior to anything to prevent other users to overwrite our c…
Dec 11, 2025
6db191f
attempt to work in a secure directory
Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 13 additions & 20 deletions SUDO_KILLERv3.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,6 @@ init() {
if [ -z "$cnver" ]; then
echo "Error: The tool has not been able to convert the sudo's version!"
fi

if [ -n "$path" ]; then
vpath="$path/sudo_killer-export-$(date +'%d-%m-%y')"
else
vpath="/tmp/sudo_killer-export-$(date +'%d-%m-%y')"
fi

# Create the directory
mkdir -p "$vpath"
} # init

#------------------------------------------------------
Expand Down Expand Up @@ -1019,7 +1010,7 @@ fn_miss_scripts() {
#echo $line

# missing file/script
if [ ! -f $line ]; then
if [ ! -f "$line" ]; then

rep=$(echo "$line" | awk -F.sh '{print $1}' | rev | cut -d "/" -f 2,3,4,5,6,7 | rev | cut -d " " -f 2)

Expand Down Expand Up @@ -1140,7 +1131,7 @@ fn_excessive_dir_perm() {
####### [DIRECTORY]

# checking the directory rights of the scripts identified in sudo
if [ -f $liney ]; then
if [ -f "$liney" ]; then
rep1=$(echo "$liney" | awk -F.sh '{print $1}' | rev | cut -d "/" -f 2,3,4,5,6,7 | rev | cut -d " " -f 2)

echo -e "\n"
Expand Down Expand Up @@ -2142,19 +2133,21 @@ call_each() {
# call_each 2> /dev/null
# fi

umask 077

if [ -n "$path" ]; then
vpath="$path/sudo_killer-export-$(date +'%d-%m-%y')"
mkdir "$vpath" || echo "path already exists" && exit 1
else
vpath=$(mktemp -d -t sudo_killer-export-XXXXXXXXXX)
fi

if [ "$path" ]; then
mkdir -p /$path/sudo_killer-export-$(date +"%d-%m-%y") 2>/dev/null
call_each | tee -a /$path/sudo_killer-export-$(date +"%d-%m-%y")/$report 2>/dev/null
call_each | tee -a "$vpath"/"$report" 2>/dev/null
else
:
if [ "$report" ] || [ "$export" ]; then
mkdir -p /tmp/sudo_killer-export-$(date +"%d-%m-%y") 2>/dev/null
call_each | tee -a /tmp/sudo_killer-export-$(date +"%d-%m-%y")/$report 2>/dev/null
call_each | tee -a "$vpath"/"$report" 2>/dev/null
else
:
call_each 2>/dev/null
fi

fi