chore: improve pr-agent maintenance path

[lphuc2250gma]

Summary:

• Add or tighten focused edge-case tests or type assertions in tests/health_test/main.py, tests/e2e_tests/e2e_utils.py related to Python typing, tests, CLI ergonomics, observability; avoid docs-only changes and broad refactors.
• Keep the change narrow so it is straightforward to review.

Notes:

• I kept this scoped to the relevant implementation and tests.

[qodo-free-for-open-source-projects]

Review Summary by Qodo

Add type annotations and improve test assertions

🧪 Tests ✨ Enhancement

Walkthroughs

Description

• Add type annotations to module-level variables in e2e_utils.py
• Add return type annotations to async and sync functions in health_test/main.py
• Enhance assertions with type checks and descriptive error messages
• Improve test robustness and maintainability through explicit typing

Diagram

flowchart LR
  A["e2e_utils.py<br/>Module Variables"] -->|"Add type hints"| B["FILE_PATH: str<br/>NUM_MINUTES: int<br/>NEW_FILE_CONTENT: str"]
  C["health_test/main.py<br/>Functions"] -->|"Add return types"| D["run_async() -> None<br/>run() -> None"]
  E["health_test/main.py<br/>Assertions"] -->|"Enhance with type checks<br/>and messages"| F["isinstance() checks<br/>Descriptive error messages"]
  B --> G["Improved Type Safety"]
  D --> G
  F --> G

Loading

File Changes

1. tests/e2e_tests/e2e_utils.py ✨ Enhancement +3/-3

Add type annotations to module constants

• Add explicit type annotations to module-level constants: FILE_PATH: str, NUM_MINUTES: int,
 NEW_FILE_CONTENT: str
• Improve code clarity and enable static type checking for test utilities

tests/e2e_tests/e2e_utils.py

---

2. tests/health_test/main.py 🧪 Tests +11/-5

Add type hints and strengthen test assertions

• Add return type annotation -> None to run_async() and run() functions
• Enhance assertions with explicit isinstance() type checks for artifact values
• Add descriptive error messages to assertions for better debugging and test failure clarity
• Improve test robustness by validating artifact types before string operations

tests/health_test/main.py

---

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📜 Skill insights (0)

1. pr_header_body uses single quotes ✓ Resolved 📘 Rule violation ⚙ Maintainability

Description

New assertions in run_async() introduce single-quoted string literals (e.g., '###', '##', `'PR
Type', 'PR Reviewer Guide', 'PR Code Suggestions'`) where the repository Ruff style requires
double quotes. This can cause Ruff/pre-commit failures and inconsistent style across the codebase.

Code

tests/health_test/main.py[R34-35]

+        assert pr_header_body.startswith('###') and 'PR Type' in pr_header_body and 'Description' in pr_header_body, \
+            "PR description artifact missing expected sections"

Evidence

PR Compliance ID 9 requires Python changes to follow Ruff style, including preferring double quotes,
and the cited modified lines show newly added assert statements using single-quoted string
literals (such as section markers like '###'/'##' and labels like 'PR Type', `'PR Reviewer
Guide', and 'PR Code Suggestions'`), demonstrating the style mismatch that could trigger
Ruff/pre-commit failures.

AGENTS.md: Python Code Must Conform to Ruff/pyproject.toml Style (120-char lines, isort ordering, double quotes): AGENTS.md: Python Code Must Conform to Ruff/pyproject.toml Style (120-char lines, isort ordering, double quotes): AGENTS.md: Python Code Must Conform to Ruff/pyproject.toml Style (120-char lines, isort ordering, double quotes): AGENTS.md: Python Code Must Conform to Ruff/pyproject.toml Style (120-char lines, isort ordering, double quotes): AGENTS.md: Python Code Must Conform to Ruff/pyproject.toml Style (120-char lines, isort ordering, double quotes): AGENTS.md: Python Code Must Conform to Ruff/pyproject.toml Style (120-char lines, isort ordering, double quotes): AGENTS.md: Python Code Must Conform to Ruff/pyproject.toml Style (120-char lines, isort ordering, double quotes): AGENTS.md: Python Code Must Conform to Ruff/pyproject.toml Style (120-char lines, isort ordering, double quotes)
tests/health_test/main.py[34-35]
tests/health_test/main.py[45-46]
tests/health_test/main.py[56-57]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The newly added asserts in `run_async()` use single-quoted string literals, but the repo style requires double quotes per Ruff configuration.
## Issue Context
Update the new string literals in these asserts to use double quotes (e.g., replace `'###'`/`'##'` and labels like `'PR Type'`, `'PR Reviewer Guide'`, `'PR Code Suggestions'`, and related strings such as `'Description'` with their double-quoted equivalents).
## Fix Focus Areas
- tests/health_test/main.py[34-35]
- tests/health_test/main.py[45-46]
- tests/health_test/main.py[56-57]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

• Author self-review: I have reviewed the code review findings, and addressed the relevant ones.

Previous review results

Review updated until commit 6f6e8bd

Results up to commit 94821d8

🐞 Bugs (0) 📘 Rule violations (1)

1. pr_header_body uses single quotes 📘 Rule violation ⚙ Maintainability

Description

New assertions in run_async() introduce single-quoted string literals (e.g., '###', '##', `'PR
Type', 'PR Reviewer Guide', 'PR Code Suggestions'`) where the repository Ruff style requires
double quotes. This can cause Ruff/pre-commit failures and inconsistent style across the codebase.

Code

tests/health_test/main.py[R34-35]

+        assert pr_header_body.startswith('###') and 'PR Type' in pr_header_body and 'Description' in pr_header_body, \
+            "PR description artifact missing expected sections"

Evidence

PR Compliance ID 9 requires Python changes to follow Ruff style, including preferring double quotes,
and the cited modified lines show newly added assert statements using single-quoted string
literals (such as section markers like '###'/'##' and labels like 'PR Type', `'PR Reviewer
Guide', and 'PR Code Suggestions'`), demonstrating the style mismatch that could trigger
Ruff/pre-commit failures.

AGENTS.md: Python Code Must Conform to Ruff/pyproject.toml Style (120-char lines, isort ordering, double quotes)
tests/health_test/main.py[34-35]
tests/health_test/main.py[45-46]
tests/health_test/main.py[56-57]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The newly added asserts in `run_async()` use single-quoted string literals, but the repo style requires double quotes per Ruff configuration.

## Issue Context
Update the new string literals in these asserts to use double quotes (e.g., replace `'###'`/`'##'` and labels like `'PR Type'`, `'PR Reviewer Guide'`, `'PR Code Suggestions'`, and related strings such as `'Description'` with their double-quoted equivalents).

## Fix Focus Areas
- tests/health_test/main.py[34-35]
- tests/health_test/main.py[45-46]
- tests/health_test/main.py[56-57]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

[naorpeled]

Thanks @lphuc2250gma!

[qodo-free-for-open-source-projects]

Code review by qodo was updated up to the latest commit 6f6e8bd