Skip to content

feat(ui5): Add table best practices skill#78

Open
FelixSchubert-001 wants to merge 3 commits into
UI5:mainfrom
FelixSchubert-001:feat/ui5-best-practices-tables
Open

feat(ui5): Add table best practices skill#78
FelixSchubert-001 wants to merge 3 commits into
UI5:mainfrom
FelixSchubert-001:feat/ui5-best-practices-tables

Conversation

@FelixSchubert-001

@FelixSchubert-001 FelixSchubert-001 commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

Adds a new ui5-best-practices-tables skill covering all UI5 table controls.

The skill follows a progressive-disclosure structure: SKILL.md is a short hub that Claude loads first, and per-control detail lives in reference files that are loaded only when relevant.

SKILL.md covers:

  • Control selection matrix (which table type to use and when)
  • Mandatory rules and prohibitions
  • Common errors with symptom/cause/fix
  • Valid and invalid container structures
  • Performance and accessibility checklist

Reference files (loaded on demand):

File Content
references/sap-m-table.md Binding syntax, key properties, sticky headers, responsive patterns, grouping
references/grid-table.md rowMode aggregation, selection behavior, no-data customization
references/tree-table.md Hierarchical binding (JSON, OData V2), programmatic expand/collapse
references/smart-table.md OData V2 annotations, SmartTable configuration
references/mdc-table.md Delegate pattern, fetchProperties, updateBindingInfo
references/drag-and-drop.md DragDropInfo vs. DragInfo+DropInfo, groupName rules
references/personalization.md sap.m.p13n.Engine registration and show() call
references/cell-templates.md Alignment by data type, cell template selection, model type namespaces

Also updates plugins/ui5/README.md to document the new skill alongside the existing ones.

JIRA: CPOUIFTEAMB-2652

Converts the table-specific guidelines from CPOUIFTEAMB-2584 (Gerrit
7245230) into a skill following the progressive-disclosure structure
recommended by Anthropic's skill guide.

SKILL.md is a short hub (144 lines) covering core rules, the control
selection matrix, common errors, and container structures. Per-control
detail lives in eight reference files loaded on demand:
sap-m-table, grid-table, tree-table, smart-table, mdc-table,
drag-and-drop, personalization, cell-templates.

@flovogt flovogt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please adjust also https://github.com/UI5/plugins-coding-agents/tree/main/plugins/ui5 to mention the new skill.
  2. Update the PR description to more readable format
  3. Mention the corresponding JIRA item via "JIRA: XXXX" in the PR description
  4. Request a review by a team member

SKILL.md is a short hub covering core rules, the control selection
matrix, common errors, and container structures. Per-control detail
lives in eight reference files loaded on demand: sap-m-table,
grid-table, tree-table, smart-table, mdc-table, drag-and-drop,
personalization, cell-templates.

Also adds the skill entry to plugins/ui5/README.md.

JIRA: CPOUIFTEAMB-2652
Comment thread plugins/ui5/README.md
@flovogt flovogt requested a review from simlin June 22, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants