-
Notifications
You must be signed in to change notification settings - Fork 52
Speed up import and load hvplot lazily #1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sevans711
wants to merge
11
commits into
UXARRAY:main
Choose a base branch
from
Sevans711:speedup-import
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+77
−3
Open
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d7ea507
Speed up import uxarray, via lazy hvplot import
Sevans711 6c395d9
test hvplot import is lazy
Sevans711 26c11fe
Merge branch 'main' into speedup-import
Sevans711 edbcf3f
fix dependency test (use fresh subprocess)
Sevans711 2745cad
fix unexpected change to hvplot.extension
Sevans711 c58471c
Merge branch 'main' into speedup-import
Sevans711 9be6f1e
fix hvplot has no Attribute 'Store' sometimes
Sevans711 b3730ec
Merge branch 'main' into speedup-import
Sevans711 2576f05
Fix lazy hvplot backend preservation to use holoviews.Store
rajeeja 507e3cc
Merge branch 'main' into speedup-import
Sevans711 5cb0c99
Merge branch 'main' into speedup-import
Sevans711 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| """ | ||
| Purpose: tests related to dependencies | ||
| e.g.: hvplot is optional, so it shouldn't be imported by default. | ||
| Related issues: #1224, #1539 | ||
| """ | ||
| import sys | ||
|
|
||
|
|
||
| def test_hvplot_optional(): | ||
| """Test that hvplot is actually optional and not imported by default. | ||
| (hvplot in particular is "slow" to import (~1s to import hvplot.pandas), | ||
| so it should not be imported until actually plotting something.) | ||
| """ | ||
| assert "hvplot" not in sys.modules # else, it's a test environment issue..? | ||
| import uxarray as ux | ||
| assert "hvplot" not in sys.modules | ||
|
|
||
|
|
||
| # TODO: similar tests for cartopy, holoviews, and other optional deps. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.