-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: preserve numeric text in table HTML metadata #4373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gyx09212214-prog
wants to merge
5
commits into
Unstructured-IO:main
Choose a base branch
from
gyx09212214-prog:gyx09212214-prog/preserve-html-table-number-text
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
34a28a8
test: guard HTML table numeric cell text
gyx09212214-prog d566717
fix: preserve numeric text in delimited table html
gyx09212214-prog 5474f43
refactor: share dataframe table html rendering
gyx09212214-prog 602be91
fix: preserve empty cells in dataframe html
gyx09212214-prog 5f52121
test: cover leading-zero table cell text
gyx09212214-prog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| import pandas as pd | ||
|
|
||
| from unstructured.chunking import add_chunking_strategy | ||
| from unstructured.common.html_table import HtmlTable | ||
| from unstructured.common.html_table import HtmlTable, htmlify_matrix_of_cell_texts | ||
| from unstructured.documents.elements import Element, ElementMetadata, Table | ||
| from unstructured.file_utils.model import FileType | ||
| from unstructured.partition.common.common import ( | ||
|
|
@@ -41,18 +41,22 @@ def partition_tsv( | |
|
|
||
| header = 0 if include_header else None | ||
|
|
||
| read_kw: dict[str, Any] = { | ||
| "sep": "\t", | ||
| "header": header, | ||
| "dtype": str, | ||
| "keep_default_na": False, | ||
| } | ||
| if filename: | ||
| dataframe = pd.read_csv(filename, sep="\t", header=header) | ||
| dataframe = pd.read_csv(filename, **read_kw) | ||
| else: | ||
| assert file is not None | ||
| # -- Note(scanny): `SpooledTemporaryFile` on Python<3.11 does not implement `.readable()` | ||
| # -- which triggers an exception on `pd.DataFrame.read_csv()` call. | ||
| f = spooled_to_bytes_io_if_needed(file) | ||
| dataframe = pd.read_csv(f, sep="\t", header=header) | ||
| dataframe = pd.read_csv(f, **read_kw) | ||
|
|
||
| html_table = HtmlTable.from_html_text( | ||
| dataframe.to_html(index=False, header=include_header, na_rep="") | ||
| ) | ||
| html_table = HtmlTable.from_html_text(_dataframe_to_html_text(dataframe, include_header)) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: Custom agent: Enforce Pragmatic Test Coverage Change to TSV partition core logic lacks test coverage Prompt for AI agents |
||
|
|
||
| metadata = ElementMetadata( | ||
| filename=filename, | ||
|
|
@@ -62,3 +66,10 @@ def partition_tsv( | |
| metadata.detection_origin = DETECTION_ORIGIN | ||
|
|
||
| return [Table(text=html_table.text, metadata=metadata)] | ||
|
|
||
|
|
||
| def _dataframe_to_html_text(dataframe: pd.DataFrame, include_header: bool) -> str: | ||
| """Render a dataframe as table HTML without pandas numeric formatting.""" | ||
| rows = dataframe.astype(str).values.tolist() | ||
| matrix = [[str(column) for column in dataframe.columns]] + rows if include_header else rows | ||
| return htmlify_matrix_of_cell_texts(matrix) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.