feat: Add local Nodemailer fallback for development email service - #225
Open
karthik768990 wants to merge 1 commit into
Open
feat: Add local Nodemailer fallback for development email service#225karthik768990 wants to merge 1 commit into
karthik768990 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a local Nodemailer fallback for sending emails in development.
It removes the dependency on SendGrid API keys for local testing and simplifies user/admin creation workflows.
Problem
Currently, developers must configure SendGrid API keys even for local development, which blocks setup.
Solution
emailServiceNodemailer.js)emailService.jsto select between SendGrid (production) and Nodemailer (local) using theEMAIL_SERVICEenvironment variable..envfile can be used for Gmail credentials for Nodemailer.Testing
.envfile inshopping-serverwith:EMAIL_SERVICE=nodemailer
VENIQA_NODEMAILER_USER=<your_gmail>
VENIQA_NODEMAILER_PASSWORD=<app_password>
npm run dev.Notes
.envshould never be committed; add it to.gitignore.###Comment: I haven't included the .env as it contains some sensitive information and the developers should create their own .env files