Skip to content

fix: Subtract Founders' Reward from block subsidy - #10338

Merged
mergify[bot] merged 1 commit into
mainfrom
fix-subsidy
Mar 19, 2026
Merged

fix: Subtract Founders' Reward from block subsidy#10338
mergify[bot] merged 1 commit into
mainfrom
fix-subsidy

Conversation

@upbqdn

@upbqdn upbqdn commented Feb 23, 2026

Copy link
Copy Markdown
Member

Motivation

Solution

  • Subtract the founders' reward from the block subsidy when calculating the miner subsidy.

Tests

  • No new tests.

AI Disclosure

  • No AI tools were used in this PR
  • AI tools were used:

PR Checklist

  • The PR name is suitable for the release notes.
  • The PR follows the contribution guidelines.
  • This change was discussed in an issue or with the team beforehand.
  • The solution is tested.
  • The documentation and changelogs are up to date.

@upbqdn upbqdn self-assigned this Feb 23, 2026
@upbqdn upbqdn added the C-bug Category: This is a bug label Feb 23, 2026
conradoplg
conradoplg reviewed Feb 23, 2026
View reviewed changes
Comment thread zebra-chain/src/parameters/network/subsidy.rs Outdated
@conradoplg conradoplg added the S-waiting-on-author Status: waiting on the ticket or PR author label Feb 25, 2026
conradoplg
conradoplg previously approved these changes Mar 5, 2026
View reviewed changes

@conradoplg conradoplg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the understanding 🙏

@oxarbitrage oxarbitrage added do-not-merge Tells Mergify not to merge this PR and removed do-not-merge Tells Mergify not to merge this PR labels Mar 11, 2026
@dismad

dismad commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

Looks like this fix didn't get added to 4.2.0, may be an oversight

@conradoplg

conradoplg commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator

Indeed, it should have got in ☹️ @upbqdn any reason why this is in draft?

@upbqdn
upbqdn marked this pull request as ready for review March 19, 2026 16:01
@mergify mergify Bot added the queued label Mar 19, 2026
@mergify

mergify Bot commented Mar 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-03-19 16:01 UTC · Rule: batched
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-03-19 16:11 UTC · at 91cd41d2cda3bb29fd7afad6d34e5f4be93cf2df

This pull request spent 10 minutes 17 seconds in the queue, with no time running CI.

Required conditions to merge

@upbqdn

upbqdn commented Mar 19, 2026

Copy link
Copy Markdown
Member Author

It was the failing CI. We merged the fixes, but then I got distracted and didn't follow through on this one. It's ready now.

@mergify
mergify Bot merged commit aabb8b4 into main Mar 19, 2026
93 checks passed
@mergify
mergify Bot deleted the fix-subsidy branch March 19, 2026 16:11
@mergify mergify Bot removed the queued label Mar 19, 2026
@dismad

dismad commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Thanks guys!

@str4d str4d mentioned this pull request Mar 20, 2026
Merged
6 tasks
@oxarbitrage oxarbitrage mentioned this pull request Mar 20, 2026
Merged
judah-caruso pushed a commit to ShieldedLabs/zebra-crosslink-staging that referenced this pull request May 28, 2026
@upbqdn @judah-caruso
fix: Subtract Founders' Reward from block subsidy (ZcashFoundation#10338
c735430 
)

Subtract Founder's Reward from block subsidy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arya2 arya2 arya2 left review comments
@conradoplg conradoplg conradoplg approved these changes

Assignees

@upbqdn upbqdn

Labels

C-bug Category: This is a bug S-waiting-on-author Status: waiting on the ticket or PR author

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: getblocksubsidy does not match zcashd for older blocks

5 participants

@upbqdn @dismad @conradoplg @arya2 @oxarbitrage