fix(ci): Migrate lints from .cargo/config.toml to Cargo.toml - #10380
Merged
Conversation
upbqdn
added
C-bug
upbqdn
changed the title
.cargo/config.toml to Cargo.toml
upbqdn
changed the title
.cargo/config.toml to Cargo.toml.cargo/config.toml to Cargo.toml
upbqdn
force-pushed
the
fix/workspace-lints
branch
from
March 10, 2026 10:47
259ceea to
4eedc8a
Compare
oxarbitrage
reviewed
Mar 10, 2026
oxarbitrage
left a comment
oxarbitrage
left a comment
Contributor
There was a problem hiding this comment.
I think this looks good but will be nice to confirm it. We can add a temporary commit with:
println!("lint test");
Confirm clippy::print_stdout fires in CI, then drop the commit before merging.
Member
Author
|
Confirmed in https://github.com/ZcashFoundation/zebra/actions/runs/22908800240/job/66474979047?pr=10380#step:5:951. I'm going to remove the commit and force-push. |
upbqdn
force-pushed
the
fix/workspace-lints
branch
from
March 10, 2026 15:21
b2c88c0 to
4eedc8a
Compare
oxarbitrage
added
P-Critical 🚑
do-not-merge
The setup-rust-toolchain action sets RUSTFLAGS="-D warnings" by default, which overrides .cargo/config.toml rustflags entirely. This silently dropped all custom lints (clippy::print_stdout, unsafe_code, missing_docs, etc.) since #9883. Move lint configuration to [workspace.lints] in Cargo.toml, which is immune to RUSTFLAGS overrides. Closes #10378
upbqdn
force-pushed
the
fix/workspace-lints
branch
from
March 19, 2026 16:12
b492b05 to
01fa6d1
Compare
upbqdn
marked this pull request as ready for review
March 19, 2026 16:12
conradoplg
approved these changes
Mar 25, 2026
Contributor
Merge Queue Status
This pull request spent 4 hours 1 minute 20 seconds in the queue, including 57 seconds running CI. Required conditions to merge
|
This was referenced Mar 25, 2026
This was referenced Mar 25, 2026
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
Move lint configuration from
.cargo/config.tomlto[workspace.lints]inCargo.toml, which is immune toRUSTFLAGSenvironment variable overrides.Specifications & References
setup-rust-toolchainRUSTFLAGS behavior: https://github.com/actions-rust-lang/setup-rust-toolchain#rustflags