-
Notifications
You must be signed in to change notification settings - Fork 632
UN-2265 [FEAT] Show the running platform version on the profile page #2034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,6 +72,10 @@ RUN sed -i 's|</head>| <script src="/config/runtime-config.js"></script>\n < | |
| COPY frontend/generate-runtime-config.sh /docker-entrypoint.d/40-env.sh | ||
| RUN chmod +x /docker-entrypoint.d/40-env.sh | ||
|
|
||
| # Capture build version at the very end so it doesn't affect layer caching | ||
| ARG VERSION=dev | ||
| ENV UNSTRACT_APPS_VERSION=${VERSION} | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @athul-rs does this get set during cloud builds as well?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes — cloud frontend builds go through docker bake with
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @athul-rs doesn't it mean we will show rc tags in the UI?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ritwik-g It is relatively ok to show @athul-rs That being said, since we re-tag an existing |
||
|
|
||
| EXPOSE 80 | ||
|
|
||
| USER nginx | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.