Change to ES6 Classes#40
Merged
Merged
Conversation
Author
|
@rzr as said other PR merge other independent. Idea is to release new version after having merged both. |
Collaborator
|
Please resolve conflict |
Author
|
@rzr fixed |
Collaborator
|
This branch cannot be rebased due to conflicts |
Author
|
According to Github it has no conflicts. Noidea why rebase do not work Just do squash&merge |
Collaborator
|
it looks like a bug, I can't rebase from GUI can you try it and push -f ? |
Author
|
But why rebase? Just choose squash&merge. |
Author
|
@rzr thank you. Which version increase we should do because both PRs were breaking. Formally a major increase. |
Collaborator
|
yea let's do this... May I suggest to also announce it at: |
Merged
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an adjustment (and yes breaking because now classes and no function constructs are used) of the code and I would like to merge this for more convenient usage in these times.
I also tested it with the test scripts "in real live"