fix: make sure trackpad taps properly fire press events consistently by LFDanLu · Pull Request #10225 · adobe/react-spectrum

LFDanLu · 2026-06-17T23:48:39Z

✅ Pull Request Checklist:

Included link to corresponding React Spectrum GitHub Issue.
Added/updated unit tests and storybook for this change (for new code or code which already has tests).
Filled out test instructions.
Updated documentation (if it already exists for this component).
Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Make sure you have tap to click enabled for your track pad. Attempt to tap on checkboxes in FireFox and verify it always toggles the checkbox on tap. Test other browser/device/screenreader combinations.

🧢 Your Project:

RSP

snowystinger · 2026-06-17T23:57:40Z

+        // oxlint-disable-next-line no-unused-vars
+        using uaMock = jest


Suggested change

// oxlint-disable-next-line no-unused-vars

using uaMock = jest

using _uaMock = jest

I think this will pass

unfortunately still caught by the linter :(

rspbot · 2026-06-18T00:03:37Z

Build successful! 🎉

snowystinger · 2026-06-18T00:06:38Z

Possibly the Safari bug if we want to chime in https://bugs.webkit.org/show_bug.cgi?id=206216

snowystinger

This worked well for me on Mac in FF

fix: resolve lint and CI test compilation errors fix(table): floor fractional table width so columns don't overflow (adobe#10238) * fix(table): floor fractional table width so columns don't overflow calculateColumnSizes relies on cascadeRounding, which assumes the target column sizes sum to an integer. With a fractional table width (e.g. a percentage-based size) that invariant breaks and the rounded widths can exceed the available width by 1px, producing an unexpected horizontal scrollbar. Flooring the available width keeps the sum integral; integer widths are unchanged. Adds a regression test to TableUtils. Fixes adobe#9448. * Keep columns flush with a fractional table width Address review: instead of flooring the available width (which left a sub-pixel gap between the last column and the table edge), assign the leftover fraction to the last column inside cascadeRounding so the column widths sum exactly to the available width. Integer widths are unchanged. * Fix failing resize tests; keep integer widths whole The previous revision added the fractional remainder inside cascadeRounding using `fpTotal - intTotal`, but floating-point accumulation could leave a tiny residue on the last column even for integer table widths, breaking tests that assume whole-number widths (e.g. tableResizingTests). Revert cascadeRounding to its integer-only form and instead split the available width in calculateColumnSizes: distribute the floored (whole-pixel) width across the columns, then add the leftover fraction to the last column. Integer widths are now exactly whole numbers again, and a fractional width (e.g. 1000.5 -> [500, 500.5]) keeps the columns flush with the table edge. * Add test for fractional table widths with fp rounding error Covers a table width like 1000.7 where the leftover fraction lands on the last column. The columns still sum exactly to the available width and all but the last column are whole numbers; the last column is within one ULP of the expected fractional value. * use number string manipulation to make exact math --------- Co-authored-by: Rob Snow <rsnow@adobe.com> fix: shadcn registry build (adobe#10263) fix: make sure trackpad taps properly fire press events consistently (adobe#10225) * fix: make sure trackpad taps are not considered as virtual clicks * didnt save? fix(dialog): add aria-describedby support for alertdialog role (adobe#9924) * fix(dialog): add aria-describedby support for alertdialog role AlertDialog was rendering with role="alertdialog" but without aria-describedby, which the WAI-ARIA spec recommends for alertdialogs to reference the alert message content. Changes: - useDialog hook: generate a content ID via useSlotId when role is "alertdialog", return contentProps with the ID, and set aria-describedby on the dialog element - V3 Dialog: spread contentProps onto the content slot so the Content element receives the generated ID - RAC Dialog: destructure contentProps (available for user composition) The aria-describedby is only auto-wired for alertdialog role. Regular dialogs are unaffected. Users can override via the aria-describedby prop. Fixes adobe#9916 * fix: wire contentProps via TextContext for RAC alertdialog aria-describedby * test: add RAC integration test for alertdialog aria-describedby via Text slot * fix: sort TextContext import alphabetically in RAC Dialog * update tests, add warning to RAC * add describedby to s2 alert dialog * fix test * refactor, add tests, fix image labels in examples * fix lint * fix: allow aria-describedby override in v3 AlertDialog Extends SpectrumAlertDialogProps with AriaLabelingProps and passes {labelable: true} to filterDOMProps so user-supplied aria-describedby flows through to the inner Dialog instead of being stripped. Mirrors the S2 AlertDialog treatment already merged by snowystinger, and aligns v3 AlertDialog with regular v3 Dialog, which has these props transitively via AriaDialogProps. Adds a test verifying the override reaches the rendered alertdialog element. * fix(useDialog): drop contentId when aria-describedby is user-provided If the consumer supplies their own aria-describedby on an alertdialog, useDialog no longer generates a slot id for contentProps. This mirrors the existing handling of titleId vs aria-label and prevents downstream wrappers (e.g. RAC Dialog's TextContext for the description slot) from receiving an id no one references. Adds a test covering the override path. * fix(s2): wire aria-describedby on S2 AlertDialog via explicit contentId Generates a contentId in S2 AlertDialog and passes it to both the underlying Dialog (as aria-describedby) and to <Content /> (as id). This puts the aria-describedby target directly on the Content element rather than on the Text slot wrapper, and keeps the wiring contained within AlertDialog instead of relying on the RAC TextContext path. A consumer-supplied aria-describedby continues to take precedence; in that case we omit the generated id from <Content /> so we don't add an unused id. * fix(s2): import useId from react-aria/useId, not 'react' React.useId is React 18+ only, breaking test-16 and test-17 in CI. Every other S2 file uses the polyfilled useId from react-aria/useId. * fix some merge changes * move warning down to hook and remove extra code from s2 * test: use renamed DialogTester.getDialog() API after merge main renamed the DialogTester getters to methods (get dialog() -> getDialog()). The alertdialog aria-describedby test still used the old .dialog getter, which now returns undefined and fails the assertions. Match the getDialog() API already used elsewhere in this file. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * make more forgiving since spec says "should" --------- Co-authored-by: Yihui Liao <44729383+yihuiliao@users.noreply.github.com> Co-authored-by: Rob Snow <rsnow@adobe.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> fix: re-export RenderProps-related types from react-aria-components to (adobe#9955) fix downstream TS2742 The v1.17.0 types refactor split the bundled types.d.ts into per-source files. RenderProps extends StyleRenderProps extends DOMRenderProps, and StyleRenderProps['style'] uses StyleOrFunction — neither was publicly nameable. Downstream packages built with composite/declaration emit then fail with TS2742 on any inferred type whose expansion crosses these names. Adds `export` to StyleOrFunction and re-exports DOMRenderProps, PossibleLinkDOMRenderProps, DOMRenderFunction, ClassNameOrFunction, StyleOrFunction, and ChildrenOrFunction from the package entry. Type-only, additive — no runtime impact. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: Robert Snow <rsnow@adobe.com> fix(useId): prevent FinalizationRegistry entry leak in useId (adobe#9853) * fix(useId): avoid FinalizationRegistry entry leak in useId * fix test in React 16/17 * add comments to test * additional test: changing the id should unregister the old token and register the new one --------- Co-authored-by: Robert Snow <rsnow@adobe.com> fix: prefer ancestor drop target over nearest-by-distance in DragManager (adobe#10170) Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com> Co-authored-by: Robert Snow <rsnow@adobe.com>

fix: make sure trackpad taps are not considered as virtual clicks

374964c

LFDanLu added the needs testing label Jun 17, 2026

didnt save?

cbef46e

snowystinger reviewed Jun 17, 2026

View reviewed changes

snowystinger approved these changes Jun 23, 2026

View reviewed changes

LFDanLu marked this pull request as ready for review June 23, 2026 16:28

LFDanLu changed the title ~~fix: (WIP) make sure trackpad taps are not considered as virtual clicks~~ fix: make sure trackpad taps are not considered as virtual clicks Jun 23, 2026

LFDanLu changed the title ~~fix: make sure trackpad taps are not considered as virtual clicks~~ fix: make sure trackpad taps properly fire press events consistenly Jun 23, 2026

LFDanLu changed the title ~~fix: make sure trackpad taps properly fire press events consistenly~~ fix: make sure trackpad taps properly fire press events consistently Jun 23, 2026

LFDanLu added ready for review and removed needs testing labels Jun 23, 2026

devongovett approved these changes Jun 25, 2026

View reviewed changes

snowystinger added this pull request to the merge queue Jun 25, 2026

Merged via the queue into main with commit 052ac7b Jun 25, 2026
33 checks passed

snowystinger deleted the 10184 branch June 25, 2026 22:45

reidbarber mentioned this pull request Jun 29, 2026

ChatGPT Atlas #10277

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: make sure trackpad taps properly fire press events consistently - #10225

fix: make sure trackpad taps properly fire press events consistently#10225
snowystinger merged 2 commits into
mainfrom
10184

LFDanLu commented Jun 17, 2026

Uh oh!

snowystinger Jun 17, 2026

Uh oh!

LFDanLu Jun 18, 2026

Uh oh!

rspbot commented Jun 18, 2026

Uh oh!

snowystinger commented Jun 18, 2026

Uh oh!

snowystinger left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		// oxlint-disable-next-line no-unused-vars
		using uaMock = jest

	// oxlint-disable-next-line no-unused-vars
	using uaMock = jest
	using _uaMock = jest

Uh oh!

Conversation

LFDanLu commented Jun 17, 2026

✅ Pull Request Checklist:

📝 Test Instructions:

🧢 Your Project:

Uh oh!

snowystinger Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

LFDanLu Jun 18, 2026

Choose a reason for hiding this comment

Uh oh!

rspbot commented Jun 18, 2026

Uh oh!

snowystinger commented Jun 18, 2026

Uh oh!

snowystinger left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants