test: smoke tests with declarative opt-in for examples/ - #2649
Open
jbohanon wants to merge 6 commits into
Open
Conversation
Config validation runs on every PR (validate_examples.rs), but nothing actually runs the examples, so runtime breakage and drift in external deps (npx MCP servers, provider APIs) slips through unnoticed. Add a scheduled functional layer. The runner (test/examples, behind the `examples` build tag) is data-driven: an example opts in with a smoke.yaml next to its config declaring mock upstreams and HTTP/MCP probes, so adding coverage needs no Go. Covers traffic-http, mcp-basic and llm-basic; llm-basic points every model at a prompt-reflecting mock so it stays free and deterministic. Runs against the latest nightly binary instead of building from source: no Rust build, and it exercises a real shipped artifact. The linux nightly is a static musl build, so nothing extra is needed on the runner. Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
The readiness poll was a hand-rolled loop around an unbounded http.Get. Swap it for require.Eventually and give each request a client timeout, so a hung connection can't run past the overall deadline. Use t.Context() for the gateway process and the MCP/readiness requests instead of context.Background(). It's canceled just before a subtest's cleanups, so it drops the manual cancel plumbing and lets a timed-out test abort in-flight work rather than waiting on its own timeout. Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
Signed-off-by: Jacob Bohanon <jacob.bohanon@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.