Skip to content

refactor: removes bid deselection on bid selection dialog close#3418

Merged
stalniy merged 2 commits into
mainfrom
refactor/bid-selection-dialog
Jul 13, 2026
Merged

refactor: removes bid deselection on bid selection dialog close#3418
stalniy merged 2 commits into
mainfrom
refactor/bid-selection-dialog

Conversation

@stalniy

@stalniy stalniy commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Why

because this may be confusing in multi placement deployment

What

Summary by CodeRabbit

  • Bug Fixes
    • Going back from the deployment review modal now closes it without clearing the selected provider.
    • Review modals no longer close unintentionally when pressing Escape or interacting outside the modal.
    • Updated review flow checks so the “back to marketplace” option is no longer shown after dismissing via Back.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f4a10490-8284-41fe-9bdc-56781bdec681

📥 Commits

Reviewing files that changed from the base of the PR and between 41b306a and 1e51a0e.

📒 Files selected for processing (5)
  • apps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigurationPane/GpuCard/GpuCard.spec.tsx
  • apps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigureDeploymentForm/ConfigureDeploymentForm.spec.tsx
  • apps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigureDeploymentForm/ConfigureDeploymentForm.tsx
  • apps/deploy-web/src/components/deployments/ConfigureDeployment/ReviewAndDeployModal/ReviewAndDeployModal.tsx
  • apps/deploy-web/src/context/ServicesProvider/ServicesProvider.tsx
💤 Files with no reviewable changes (1)
  • apps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigureDeploymentForm/ConfigureDeploymentForm.spec.tsx
🚧 Files skipped from review as they are similar to previous changes (3)
  • apps/deploy-web/src/context/ServicesProvider/ServicesProvider.tsx
  • apps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigureDeploymentForm/ConfigureDeploymentForm.tsx
  • apps/deploy-web/src/components/deployments/ConfigureDeployment/ReviewAndDeployModal/ReviewAndDeployModal.tsx

📝 Walkthrough

Walkthrough

The deployment review flow now preserves provider selection when returning via Back, prevents implicit Escape and outside-interaction dismissal, extends a locked GPU test timeout, and updates the NetworkId import path.

Changes

Deployment review flow

Layer / File(s) Summary
Preserve provider selection on Back
apps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigureDeploymentForm/ConfigureDeploymentForm.tsx, apps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigureDeploymentForm/ConfigureDeploymentForm.spec.tsx
Back closes the review modal without clearing the focused provider selection, and the test verifies the modal is dismissed.
Control modal dismissal interactions
apps/deploy-web/src/components/deployments/ConfigureDeployment/ReviewAndDeployModal/ReviewAndDeployModal.tsx
Escape and outside interactions are prevented.
Adjust GPU test timing
apps/deploy-web/src/components/deployments/ConfigureDeployment/ConfigurationPane/GpuCard/GpuCard.spec.tsx
The locked GPU configuration test uses a 15-second timeout.

Services provider typing

Layer / File(s) Summary
Update NetworkId import
apps/deploy-web/src/context/ServicesProvider/ServicesProvider.tsx
NetworkId is imported from the web chain SDK entry point without changing provider wiring.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: baktun14, ygrishajev

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/bid-selection-dialog

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.02%. Comparing base (e940a94) to head (1e51a0e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3418      +/-   ##
==========================================
- Coverage   72.08%   71.02%   -1.06%     
==========================================
  Files        1157     1067      -90     
  Lines       29350    27017    -2333     
  Branches     7244     6786     -458     
==========================================
- Hits        21157    19190    -1967     
+ Misses       7197     6863     -334     
+ Partials      996      964      -32     
Flag Coverage Δ *Carryforward flag
api 85.57% <ø> (ø) Carriedforward from e940a94
deploy-web 60.86% <100.00%> (-0.02%) ⬇️
log-collector ?
notifications 91.44% <ø> (ø) Carriedforward from e940a94
provider-console 81.38% <ø> (ø) Carriedforward from e940a94
provider-inventory ?
provider-proxy 86.42% <ø> (ø) Carriedforward from e940a94
tx-signer ?

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...onfigureDeploymentForm/ConfigureDeploymentForm.tsx 86.75% <100.00%> (-0.09%) ⬇️
...ment/ReviewAndDeployModal/ReviewAndDeployModal.tsx 94.73% <100.00%> (+0.29%) ⬆️
.../src/context/ServicesProvider/ServicesProvider.tsx 28.20% <ø> (ø)

... and 92 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stalniy stalniy force-pushed the refactor/bid-selection-dialog branch from 165e034 to 1e51a0e Compare July 13, 2026 08:34
@stalniy stalniy enabled auto-merge July 13, 2026 08:35
@stalniy stalniy added this pull request to the merge queue Jul 13, 2026
Merged via the queue into main with commit 6004604 Jul 13, 2026
57 checks passed
@stalniy stalniy deleted the refactor/bid-selection-dialog branch July 13, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants