Renovate updates - #4117
Conversation
…4084) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…4098) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…de-7.x chore(deps): update actions/setup-node action to v7
chore(deps): update dependency jwks-rsa>jose to v6
chore(deps): update dependency oxlint-tsgolint to v7
chore(deps): update dependency vercel to v58
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
|
Extension version is updated from |
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
Fixed security issues:
-
postcss (link)
-
sharp (link)
-
The comment above the
jwks-rsa>joseoverride still refers to the dual CJS/ESM 4.15.9 workaround, but the override now targets 6.2.4; update the comment to reflect the new rationale or confirm this workaround is still needed with the newer jose version.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The comment above the `jwks-rsa>jose` override still refers to the dual CJS/ESM 4.15.9 workaround, but the override now targets 6.2.4; update the comment to reflect the new rationale or confirm this workaround is still needed with the newer jose version.
## Individual Comments
### Comment 1
<location path="pnpm-workspace.yaml" line_range="9-10" />
<code_context>
version: 5.0.14
overrides:
- jwks-rsa>jose: 4.15.9
+ jwks-rsa>jose: 6.2.4
importers:
</code_context>
<issue_to_address>
**issue (bug_risk):** The jose override version no longer matches the explanatory comment and may no longer be API-identical.
The override comment still references jose 4.15.9 as API-identical for importJWK/exportSPKI and tied to specific upstream issues, but the override is now 6.2.4. Please either (a) verify that jwks-rsa behaves correctly with jose 6.x for these APIs in this usage, or (b) update/remove the comment so it accurately explains why we pin 6.2.4. As-is, the mismatch between the pinned version and the comment could be misleading and hide potential compatibility issues.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
@greptile review |
Renovate bumped the `jwks-rsa>jose` override from 4.15.9 to 6.2.4, which satisfies jwks-rsa's own `^6.1.3` range and therefore made the override a no-op. jose@6 is ESM-only and jwks-rsa require()s it, so every authenticated tRPC call 500s on Vercel with ERR_REQUIRE_ESM. This does not reproduce locally: `next build`, `next start` and Node 24 all handle require(ESM) fine. Confirmed only via a preview deployment's runtime logs; restoring the pin returns the route to a correct 401. Also disable Renovate updates for this override so :automergeMinor cannot reintroduce the crash, and drop three stale react-compiler oxlint-disable directives that were failing lint:ci and blocking all deploys. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Check if the Pull Request fulfils these requirements
Greptile Summary
The PR updates application, build, and CI dependencies while preserving the CommonJS-compatible
joseoverride required by Firebase Admin authentication.jwks-rsa>josecompatibility override from Renovate updates.Confidence Score: 5/5
The PR appears safe to merge.
The previously reported authentication failure is fixed: the workspace override remains in place, the lockfile resolves
jwks-rsato the CommonJS-compatiblejose@4.15.9, and Renovate is prevented from updating that override, so no blocking failure remains.Reviews (2): Last reviewed commit: "fix: restore jose 4.15.9 pin under jwks-..." | Re-trigger Greptile
Context used: