Skip to content

Resolves #218: Pull earlier version of Quiche #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rhymeswithmogul wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Resolves #218: Pull earlier version of Quiche #220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0754dbf
Pull earlier version of Quiche
rhymeswithmogul Jan 27, 2022
5320095
Update for best practices.
rhymeswithmogul Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion nginx-autoinstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,27 @@ case $OPTION in
# HTTP3
if [[ $HTTP3 == 'y' ]]; then
cd /usr/local/src/nginx/modules || exit 1
git clone --depth 1 --recursive https://github.com/cloudflare/quiche

#region Solve issue 218
# A recent commit to Quiche broke the HTTP/3 patches. Thus, we need to
# revert to an older commit so that we can build it correctly. This is
# a very bad idea, as we won't get any security fixes that might be put
# into Quiche. However, it will let NGINX compile. Please periodically
# test and see if the `git reset` is still longer needed.
git clone --recursive https://github.com/cloudflare/quiche
cd quiche || exit 1
git reset --hard 2649457a566e320bbb4edc74d5a26fd8f6a22547
cd deps || exit 1

# Pulling Quiche back to an older commit deletes the included version
# of BoringSSL. Clone the specific commit that Cloudflare uses.
git clone https://github.com/google/boringssl
cd boringssl || exit 1
git reset --hard f1c75347daa2ea81a941e953f2263e0a4d970c8d

cd ../../.. || exit 1
#endregion

# Dependencies for BoringSSL and Quiche
apt-get install -y golang
# Rust is not packaged so that's the only way...
Expand Down