docs: add ChangeDetectionStrategy.Eager to Autocomplete examples#33450
Open
msmallest wants to merge 1 commit into
Open
docs: add ChangeDetectionStrategy.Eager to Autocomplete examples#33450msmallest wants to merge 1 commit into
ChangeDetectionStrategy.Eager to Autocomplete examples#33450msmallest wants to merge 1 commit into
Conversation
msmallest
force-pushed
the
docs-autocomplete-eager
branch
from
1b86dd2 to
67c054f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation examples were made when Zone.js and Eager change detection were default. This has caused issues, see issue: #33443.
Explicitly adding
changeDetection: ChangeDetectionStrategy.Eagerto StackBlitz examples is one key piece needed in the current times. Until a sweep through all the examples makes them compatible with both new change detection defaults.On the scale of: PR to make everything zoneless + OnPush default compatible > PR to make all examples have zone + Eager for now> make one PR to provide zone and separate PR for various component examples for now, I assume the last one like this PR is the most realistic.
This is the first of my proposed "separate PR for various component examples for now" plan. Provided there are no objections, I am just going to go down the line alphabetically in individual PRs.
edit: the zone provider PR: #33449
edit: I will not open more PRs unless I get maintainer approval