fix(material/tabs): validate animation duration#33452
Open
crisbeto wants to merge 1 commit into
Open
Conversation
Adds some logic to validate the animation duration for the data before assigning it to the DOM. Along the same lines as 0df0042.
ok7sai
approved these changes
Jun 26, 2026
| export function normalizeDuration(value: string | number): string { | ||
| const stringValue = value + ''; | ||
|
|
||
| if (/^[0-9]+(?:\.[0-9]+)?$/.test(stringValue)) { |
Member
There was a problem hiding this comment.
Should it be /^[0-9]*? * instead of + because number like .5 is valid in CSS
Member
Author
There was a problem hiding this comment.
That's a good point, although we also didn't support it until now either. I'll keep it simple for now and we can revisit if anybody runs into it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some logic to validate the animation duration for the data before assigning it to the DOM. Along the same lines as 0df0042.