Fix metadata updater JSON handling#24155
Merged
Merged
Conversation
Signed-off-by: Minh Vu <vuhoangminh97@gmail.com>
oscerd
approved these changes
Jun 20, 2026
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
oscerd
approved these changes
Jun 20, 2026
davsclaus
approved these changes
Jun 20, 2026
davsclaus
left a comment
Contributor
There was a problem hiding this comment.
Clean fix — replacing manual string formatting with json.dumps() properly handles escaping for special characters, and the no-match error exit is the right behavior for a CI script. LGTM.
Minor note: commit title doesn't follow the CAMEL-XXXX: convention, but this is a CI infrastructure fix so it's not a blocker.
This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The metadata updater manually wrapped strings in quotes while preserving the generated Jackson-like layout. That could emit invalid JSON when existing metadata values or new service versions contained characters that need escaping. The script also ignored update results, so a missing match could leave generated metadata stale while the workflow continued.
Validation
python3 -m py_compile .github/actions/check-container-upgrade/update-metadata-version.pygit diff --check