Skip to content

[NAS Backup] Suppress Errors in Disk Usage Calculation that Caused Backup to Fail. #13424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daviftorres wants to merge 17 commits into
base: main
Choose a base branch
from
+6 −4
Open

[NAS Backup] Suppress Errors in Disk Usage Calculation that Caused Backup to Fail. #13424

Changes from 15 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9755ba5
Merge pull request #1 from apache/main
daviftorres Oct 21, 2025
e476a68
Merge branch 'apache:main' into main
daviftorres Nov 4, 2025
de4adaa
Merge branch 'apache:main' into main
daviftorres Nov 18, 2025
efafe00
Merge branch 'apache:main' into main
daviftorres Mar 6, 2026
6e9af51
Merge branch 'apache:main' into main
daviftorres Mar 26, 2026
b6b5bfd
Merge branch 'apache:main' into main
daviftorres Mar 31, 2026
4684396
Merge branch 'apache:main' into main
daviftorres Mar 31, 2026
c3e1471
Merge branch 'apache:main' into main
daviftorres Jun 15, 2026
4928151
Suppress errors in disk usage calculation
daviftorres Jun 15, 2026
0efaf6d
Merge branch 'main' into nas-backup-failed
daviftorres Jun 16, 2026
6e832f1
Update nasbackup.sh
daviftorres Jun 17, 2026
1c0287d
Implement timeout for unmounting in nasbackup.sh
daviftorres Jun 17, 2026
9217905
Merge branch 'main' into nas-backup-failed
daviftorres Jun 17, 2026
edc80b1
Change echo to echo -n for backup size output
daviftorres Jun 17, 2026
9ebd2d3
Merge branch 'main' into nas-backup-failed
daviftorres Jun 18, 2026
3ed133c
Merge branch 'main' into nas-backup-failed
daviftorres Jun 22, 2026
553e419
Merge branch 'main' into nas-backup-failed
daviftorres Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions scripts/vm/hypervisor/kvm/nasbackup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,12 @@ backup_running_vm() {

# Print statistics
virsh -c qemu:///system domjobinfo $VM --completed
du -sb $dest | cut -f1

umount $mount_point
rmdir $mount_point
backup_size=$(du -sb "$dest" 2>/dev/null | cut -f1) || true

@abh1sar abh1sar Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @daviftorres
Do we know the exact reason for du to fail? is that a connectivity issue?
This is the only place where the size is set on the backup. And a 0 size will affect resource limit and usage calculations.
May I suggest adding a retry loop instead?


timeout 60 umount "$mount_point" 2>/dev/null || true

@abh1sar abh1sar Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this, but can we define 60 as a constant at the top of the file?

rmdir "$mount_point" 2>/dev/null || true
Comment on lines +199 to +202
Comment on lines +201 to +202

@abh1sar abh1sar Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we log the error (using log -e) instead of silently returning true here?


Comment thread
daviftorres marked this conversation as resolved.
echo -n "$backup_size"
}

backup_stopped_vm() {
Expand Down
Loading