HTTPCLIENT-2426: Do not wrap a discarded (null) response body in a content decoder#842
Merged
Merged
Conversation
ok2c
reviewed
Jul 2, 2026
| class TestContentCompressionAsyncExecDiscard { | ||
|
|
||
| @Test | ||
| void propagatesNullDiscardOnEncodedResponse() throws Exception { |
Member
There was a problem hiding this comment.
@arturobernalg Can we add this test to TestContentCompressionAsyncExec. Why a separate test class?
Looks good otherwise
arturobernalg
force-pushed
the
HTTPCLIENT-2426
branch
from
9b3b365 to
7126115
Compare
ok2c
approved these changes
Jul 2, 2026
Member
|
@arturobernalg I think this change-set should be cherry-picked to 5.6.x |
Member
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.