Skip to content

fix: support new HugeGraph edge id format #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hutiefang76 wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix: support new HugeGraph edge id format #349

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
27b727a
fix: support new HugeGraph edge id format
hutiefang Jun 21, 2026
91a04d9
fix: align edge id coverage with current HugeGraph
hutiefang Jun 21, 2026
252ea40
fix: parse legacy edge names from edge ids
hutiefang Jun 22, 2026
b84879d
fix: tolerate current edge label schema fields
hutiefang Jun 22, 2026
bc84f0a
test: cover edge name fallback paths
hutiefang Jun 23, 2026
7fa84bd
fix: align edge compatibility with client invariants
hutiefang Jun 24, 2026
5c792eb
fix: avoid dropping current edge label fields
hutiefang Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...r/computer-core/src/main/java/org/apache/hugegraph/computer/core/input/HugeConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@
import org.apache.hugegraph.computer.core.graph.value.NullValue;
import org.apache.hugegraph.computer.core.graph.value.StringValue;
import org.apache.hugegraph.computer.core.graph.value.Value;
import org.apache.hugegraph.structure.graph.Edge;
import org.apache.hugegraph.util.E;
import org.apache.hugegraph.util.SplicingIdGenerator;

public final class HugeConverter {

Expand Down Expand Up @@ -96,4 +98,22 @@ public static Properties convertProperties(
}
return properties;
}

public static String convertEdgeName(Edge edge) {
E.checkArgumentNotNull(edge, "The edge can't be null");
String edgeId = edge.id();
if (edgeId == null) {
return edge.name();
}

String[] parts = SplicingIdGenerator.split(edgeId);
if (parts.length == 4) {

@imbajin imbajin Jun 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗️ High priority: please align this parser with the java-client edge-id invariant instead of hardcoding each length/index pair.

Context

  • Legacy client 1.3 parsed the old 4-part id as parts[2].
  • Current toolchain java-client parses the permanent 5/6-part formats in Edge.name() as idParts[idParts.length - 2] after validating the part count.
  • So the stable semantic is: Computer's edge name is the edge sort-values segment, i.e. the penultimate part of a valid edge id.

Risk

The current implementation encodes the same rule as 4 -> parts[2], 5 -> parts[3], and 6 -> parts[4]. That works for these examples, but it re-implements java-client parsing in a more fragile form and makes future format/client upgrades easier to drift.

Suggestion

Keep the compatibility range explicit, but extract through the shared invariant:

if (parts.length >= 4 && parts.length <= 6) {
    return parts[parts.length - 2];
}

Please also add a 4-part regression test beside the new 5/6-part tests, since this method explicitly preserves HugeGraph 1.3 compatibility but the current coverage only locks the new formats.

return parts[2];
} else if (parts.length == 5) {
return parts[3];
} else if (parts.length == 6) {
return parts[4];
}
return edge.name();
}
}
3 changes: 2 additions & 1 deletion ...mputer-core/src/main/java/org/apache/hugegraph/computer/core/worker/load/LoadService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,8 @@ private Edge convert(org.apache.hugegraph.structure.graph.Edge edge) {
Properties properties = HugeConverter.convertProperties(
edge.properties());
Edge computerEdge = graphFactory.createEdge(edge.label(),
edge.name(), targetId
HugeConverter.convertEdgeName(edge),
targetId
);
computerEdge.label(edge.label());
computerEdge.properties(properties);
Expand Down
19 changes: 19 additions & 0 deletions ...mputer-test/src/main/java/org/apache/hugegraph/computer/core/input/HugeConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.apache.hugegraph.computer.core.graph.value.StringValue;
import org.apache.hugegraph.computer.core.graph.value.ValueType;
import org.apache.hugegraph.computer.suite.unit.UnitTestBase;
import org.apache.hugegraph.structure.graph.Edge;
import org.apache.hugegraph.testutil.Assert;
import org.junit.Test;

Expand Down Expand Up @@ -126,4 +127,22 @@ public void testConvertProperties() {
Assert.assertEquals(properties,
HugeConverter.convertProperties(rawProperties));
}

@Test
public void testConvertEdgeNameWithFivePartEdgeId() {
Edge edge = new Edge("belong_to_el_defect");
edge.id("S1:178201>5>5>参数标准!3BA0>S4:239464");

Assert.assertEquals("参数标准!3BA0",
HugeConverter.convertEdgeName(edge));
}

@Test
public void testConvertEdgeNameWithSixPartEdgeId() {
Edge edge = new Edge("belong_to_el_defect");
edge.id("S1:178201>EDGE_OUT>5>5>参数标准!3BA0>S4:239464");

Assert.assertEquals("参数标准!3BA0",
HugeConverter.convertEdgeName(edge));
}
}
Loading