THRIFT-5955 Require C extension in Python wheels#3621
Open
vitaly-zdanevich wants to merge 1 commit into
Open
Conversation
mergeable
Bot
added
python
github_actions
vitaly-zdanevich
requested review from
Jens-G,
fishy,
jimexist and
mhlakhani
as code owners
Keep cibuildwheel release builds from silently falling back to pure-Python wheels when the fastbinary C extension fails to compile. The upstream PyPI workflow already builds manylinux aarch64 wheels; this guard makes those release wheels fail fast instead of publishing incomplete binary artifacts. Co-authored-by: OpenAI ChatGPT <noreply@openai.com>
vitaly-zdanevich
force-pushed
the
codex/publish-aarch64-python-wheels
branch
from
de65d8f to
c334760
Compare
vitaly-zdanevich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
THRIFT-5955 is about published Linux arm64 wheels. The current upstream workflow now builds those wheels, and this PR adds a safety guard so release wheel jobs fail fast instead of uploading incomplete binary artifacts if the extension build fails.
Validation
.github/workflows/pypi.ymlwith Ruby YAML.python setup.py sdist --dist-dir /tmp/thrift-py-dist.CIBUILDWHEEL=1 CXX=false python setup.py build_ext --forceand verified it fails with the new guard.git diff --check HEAD^ HEAD.Not my cup of tea - asked Codex to do it.