Skip to content

Speed up Python GraphBinary deserialization #3493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kirill-stepanishin wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −2
Open

Speed up Python GraphBinary deserialization #3493

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ebd857
Add int-keyed deserializer dispatch to reader
kirill-stepanishin Jun 15, 2026
2cfc742
Rename dispatch table to deserializer by type code
kirill-stepanishin Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions gremlin-python/src/main/python/gremlin_python/structure/io/graphbinaryV4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ class DataType(Enum):

NULL_BYTES = [DataType.null.value, 0x01]

# null type code as a plain int, so the per-read null check skips the aenum lookup
_NULL = DataType.null.value


def _make_packer(format_string):
packer = struct.Struct(format_string)
Expand Down Expand Up @@ -149,6 +152,9 @@ def __init__(self, deserializer_map=None, pdt_registry=None):
if deserializer_map:
self.deserializers.update(deserializer_map)
self.pdt_registry = pdt_registry
# Mirror of self.deserializers keyed by int type code instead of DataType.
# Avoids the per-read DataType(bt) call, whose aenum construction negatively affects performance on large results.
self._objectify_by_code = {dt.value: des.objectify for dt, des in self.deserializers.items()}
Comment thread
kirill-stepanishin marked this conversation as resolved.
Outdated

def read_object(self, b):
if b is None:
Expand All @@ -160,11 +166,15 @@ def read_object(self, b):
def to_object(self, buff, data_type=None, nullable=True):
if data_type is None:
bt = uint8_unpack(buff.read(1))
if bt == DataType.null.value:
if bt == _NULL:
if nullable:
buff.read(1)
return None
result = self.deserializers[DataType(bt)].objectify(buff, self, nullable)
try:
objectify = self._objectify_by_code[bt]
except KeyError:
raise ValueError("%r is not a valid DataType" % bt) from None
result = objectify(buff, self, nullable)
else:
result = self.deserializers[data_type].objectify(buff, self, nullable)
if self.pdt_registry is not None and isinstance(result, ProviderDefinedType):
Expand Down
Loading