TINKERPOP-2063 Add Tree support to the GLVs (Python, .NET, Go, JavaScript)#3495
Open
GumpacG wants to merge 2 commits into
Open
TINKERPOP-2063 Add Tree support to the GLVs (Python, .NET, Go, JavaScript)#3495GumpacG wants to merge 2 commits into
Tree support to the GLVs (Python, .NET, Go, JavaScript)#3495GumpacG wants to merge 2 commits into
Conversation
Tree in JS Tree in Python Tree in Go Tree in .NET Assisted-by: Kiro: Claude Opus 4.8
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3495 +/- ##
============================================
- Coverage 76.35% 76.18% -0.18%
- Complexity 13424 13864 +440
============================================
Files 1012 1031 +19
Lines 60341 62918 +2577
Branches 7075 7338 +263
============================================
+ Hits 46076 47931 +1855
- Misses 11548 12014 +466
- Partials 2717 2973 +256 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Tree support to the GLVs (Python, .NET, Go, JavaScript)Tree support to the GLVs (Python, .NET, Go, JavaScript)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings a matching native
Treetype to all Gremlin Language Variants so that a server-producedtree()result deserializes into a first-class object with the same read/navigationAPI instead of an untyped map (or, in JavaScript, a serializer stub that threw).
The work is deserialization + read-navigation focused: trees are computed on the
server and streamed to the client, so each GLV gains (1) a native
Treetype and(2) a GraphBinary
0x2b(de)serializer. A symmetric serialize path is included forround-trip/test symmetry.
What changed per variant
Treeclass instructure/graph.py;TreeIOingraphbinaryV4.py(auto-registered for
0x2b); removed the@StepTreefeature-test skip.Structure/Tree.csandGraphBinary4/Types/TreeSerializer.cs;registered
DataType.Tree; implemented the Gherkin tree-structure assertion; removedthe
@StepTreeskip.driver/tree.goplustreeType(0x2b),readTree/treeWriter, andregistration; removed the
~@StepTreecucumber tag.Treeclass instructure/graph.ts;TreeSerializer.jsreplacing the previous stub; exported
Tree; removed the named tree ignores.Testing
round-trips (nested, empty, null-key), duplicate-sibling-key collapse, element-key
equality (by id and concrete type),
childAton a missing key,addTreenullrejection,
splitParentsedge cases, andgetLeafTrees.g.V(1).out().out().tree()against the modern graphand navigate the native result.
tree()feature scenarios were un-skipped in each GLV and asserttree structure through the read API.
Notes
Treeresults travel server -> client; the serialize path exists for symmetry andround-trip tests rather than a common workflow.
https://issues.apache.org/jira/browse/TINKERPOP-2063
Assisted-by: Kiro: Claude Opus 4.8