docs: add call condition note for TSUrlHostGet#13313
Conversation
Add a note to the TSUrlHostGet documentation indicating that it should only be called after TS_HTTP_POST_REMAP_HOOK. For earlier hooks like TS_HTTP_READ_REQUEST_HDR_HOOK, TSHttpHdrHostGet should be used instead. Fixes apache#5742
|
Hello! This is my first contribution to Apache Traffic Server. Could you please trigger CI for this documentation PR? Thank you! |
|
[approve ci] |
|
@bneradt The Docs job failed due to warnings (warnings are treated as errors), but the warnings I found were related to env files. I'm not sure what the issue was. Could you take a look? |
|
From the docs build: |
|
Hi, just checking in on this docs PR. It adds a call condition note for TSUrlHostGet. Would appreciate a review when you have time. Thanks! |
Thank you for contributing, however you likely won't get a review until the docs build passes. Please see my previous comment showing the failure output. |
Replace :data: with double backticks for hook names, consistent with the rest of the documentation. Fixes apache#5742
|
Hi @bneradt, I've fixed the |
|
@mmustafasenoglu Once you are authorized to start Jenkins jobs (@bneradt added you to the whitelist) they will start automatically when you open a PR or push to it. |
Summary
Add a note to the TSUrlHostGet documentation indicating that it should only be called after TS_HTTP_POST_REMAP_HOOK.
Changes
Why
Without this note, developers may try to use TSUrlHostGet in hook phases where it won't work correctly, leading to unexpected behavior.
Fixes #5742