Skip to content

[https://github.com/apache/wicket/issues/1492] make partial page upda… #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reiern70 wants to merge 1 commit into
base: wicket-10.x
Choose a base branch
from
+17 −6
Open

[https://github.com/apache/wicket/issues/1492] make partial page upda… #1493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions wicket-core/src/main/java/org/apache/wicket/ajax/AjaxRequestHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ public class AjaxRequestHandler extends AbstractPartialPageRequestHandler implem
private final PartialPageUpdate update;

/** a set of listeners */
private Set<AjaxRequestTarget.IListener> listeners = null;
protected Set<AjaxRequestTarget.IListener> listeners = null;

/** */
private final Set<ITargetRespondListener> respondListeners = new HashSet<>();
protected final Set<ITargetRespondListener> respondListeners = new HashSet<>();

/** see https://issues.apache.org/jira/browse/WICKET-3564 */
protected transient boolean respondersFrozen;
Expand All @@ -104,7 +104,18 @@ public AjaxRequestHandler(final Page page)
{
super(page);

update = new XmlPartialPageUpdate(page)
update = newPartialPageUpdate(page);

@martin-g martin-g Jun 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/questions/3404301/whats-wrong-with-overridable-method-calls-in-constructors

It will be better to add another constructor public AjaxRequestHandler(final Page page, final PartialPageUpdate ppu)

@reiern70 reiern70 Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me... checking

@ernestosemedy ernestosemedy Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Factory method is better because constructor argument does not allow access to protected methods

@martin-g martin-g Jun 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that the overrideable method is called on an instance with unfinished construction.

}

/**
* Factory method for {@link PartialPageUpdate}'s
*
* @param page The {@link Page}
* @return an instance of {@link PartialPageUpdate}
*/
protected PartialPageUpdate newPartialPageUpdate(final Page page)
{
return new XmlPartialPageUpdate(page)
{
/**
* Freezes the {@link AjaxRequestHandler#listeners} before firing the event and
Expand All @@ -130,7 +141,7 @@ protected void onBeforeRespond(final Response response)
/**
* Freezes the {@link AjaxRequestHandler#listeners}, and does not un-freeze them as the
* events will have been fired by now.
*
*
* @param response
* the response to write to
*/
Expand All @@ -143,7 +154,7 @@ protected void onAfterRespond(final Response response)
if (listeners != null)
{
final Map<String, Component> components = Collections
.unmodifiableMap(markupIdToComponent);
.unmodifiableMap(markupIdToComponent);

for (AjaxRequestTarget.IListener listener : listeners)
{
Expand Down
2 changes: 1 addition & 1 deletion wicket-core/src/main/java/org/apache/wicket/page/PartialPageUpdate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public abstract class PartialPageUpdate
* Length of the script block that combined scripts are wrapped in. This includes the script tag,
* CDATA and if CSP is enabled also the nonce.
*/
private static final int SCRIPT_BLOCK_LENGTH = 100;
protected static final int SCRIPT_BLOCK_LENGTH = 100;

/**
* A list of scripts (JavaScript) which should be executed on the client side before the
Expand Down