Don't update global dayjs locale but make sure dayStartOfWeek can work properly - #3518
Open
pzgz wants to merge 9 commits into
Open
Don't update global dayjs locale but make sure dayStartOfWeek can work properly#3518pzgz wants to merge 9 commits into
pzgz wants to merge 9 commits into
Conversation
- No need up update global dayjs instance locale with weekStart - weekStart only need to be used when populate week of year
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Background and context
fixing for:
Basically, I don't think we need to update global dayjs locale with dayStartOfWeek set in date-picker component, doing this will make impact on global dayjs component. And we can see the inconsistent behaviors caused by this action in issue #3509.
Solution
How is the change tested?
Check the two week pickers in date-picker page, when
dayStartOfWeekis 0, 2025 has 53 weeks, at the second week picker withdayStartOfWeek = 1, we should have 52 weeks in 2025.Changelog