This repository was archived by the owner on Apr 17, 2018. It is now read-only.
Update stress test to work with 1.2.0#51
Open
keith-turner wants to merge 4 commits into
Open
Conversation
mikewalch
reviewed
Jan 30, 2018
| @@ -0,0 +1,36 @@ | |||
| ``` | |||
| mvn clean package dependency:copy-dependencies -DincludeArtifactIds=fluo-recipes-core | |||
Contributor
There was a problem hiding this comment.
Is this file still needed? It looks like it was abandoned
Member
Author
There was a problem hiding this comment.
Oh yeah, it was created and abandoned while I was working on the branch.
|
|
||
| try(FluoAdmin admin = FluoFactory.newAdmin(config)) { | ||
| // Get the application config stored in zookeeper which has Accumulo connection properties | ||
| config = new FluoConfiguration(config.orElse(admin.getApplicationConfig())); |
Member
Author
There was a problem hiding this comment.
This class needs the info to connect to accumulo. That info is not in the connections props file, so it gets it from zookeeper.
Contributor
There was a problem hiding this comment.
Ok after looking at the code again this makes sense.
mikewalch
reviewed
Jan 30, 2018
mikewalch
left a comment
mikewalch
left a comment
Contributor
There was a problem hiding this comment.
First pass. I want to try an run this myself and will review it again.
mikewalch
approved these changes
Apr 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.