taskresource/volume: add nos3readcache S3 Files mount option - #5062
Open
rsu206 wants to merge 1 commit into
Open
taskresource/volume: add nos3readcache S3 Files mount option#5062rsu206 wants to merge 1 commit into
rsu206 wants to merge 1 commit into
Conversation
Append the nos3readcache option when building S3 Files volume mount options so efs-utils does not use application memory as an in-memory read cache, keeping customer requested task memory available to the task. This matches the S3 Files mount behavior of the Fargate agent.
amogh09
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
nos3readcachemount option to S3 Files volume mounts. This optionprevents efs-utils from using application memory as an in-memory read cache,
so that customer requested task memory is not taken away by the cache.
This brings the EC2 agent's S3 Files mount behavior in line with ECS/Fargate.
Implementation details
agent/taskresource/volume/dockervolume_s3files.go:GetVolumePluginDriverOptionsnow appendsnos3readcacheto the mountoptions (
o) passed to the ECS volume plugin, after the existingtls/tlsport/iam/awscredsuri/accesspointoptions. The plugin'sECSVolumeDriverpasses the option string through to the mount commandunchanged, so no ecs-init changes are required.
Testing
go build ./...in theagentmodulego test -tags unit ./taskresource/volume/... ./api/task/...— all passgofmtcleanNew tests cover the changes: yes
(
TestGetVolumePluginDriverOptions_Basicnow assertsnos3readcacheispresent in the driver options.)
Description for the changelog
Enhancement - Add nos3readcache mount option to S3 Files volumes
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No.
Does this PR include the addition of new environment variables in the README?
No.
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.