Skip to content

Fix bugs that are not compatible with pydantic2.x - #191

Open
0x587 wants to merge 4 commits into
awtkns:masterfrom
0x587:master
Open

Fix bugs that are not compatible with pydantic2.x#191
0x587 wants to merge 4 commits into
awtkns:masterfrom
0x587:master

Conversation

@0x587

@0x587 0x587 commented Aug 17, 2023

Copy link
Copy Markdown

I solved the problem that fastapi-crudrouter is not compatible with pydantic2.x, related issue #189, #190
The changes only involve fastapi_crudrouter/core/_utils.py

@vercel

vercel Bot commented Aug 17, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fastapi-crudrouter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 0:10am

@cloudyyoung

Copy link
Copy Markdown

Hey I was wandering around for this issue/pr and I appreciate your work!
To add on, another line here would be schema.__fields__[pk_field].annotation for pydantic 2.x.

@0x587

0x587 commented Sep 13, 2023

Copy link
Copy Markdown
Author

Hey I was wandering around for this issue/pr and I appreciate your work! To add on, another line here would be schema.__fields__[pk_field].annotation for pydantic 2.x.

Thank you for your generous advice.
Then I got some useful information from https://docs.pydantic.dev/2.3/migration/#changes-to-pydanticbasemodel which suggested me to use model_fields instead of __fields__. I will append these changes to my PR later.

marcelomendoncasoares

This comment was marked as resolved.

@marcelomendoncasoares

Copy link
Copy Markdown

Hi, everyone! Very interested in this release, as this library will really accelerate the development of a project I have just started. Reading the history, is something still missing to approve? I'd be glad to help.

Comment thread fastapi_crudrouter/core/_utils.py Outdated
@lohxx

lohxx commented Oct 24, 2023

Copy link
Copy Markdown

Is there any estimate for when this PR will be merged?

@0x587

0x587 commented Oct 24, 2023

Copy link
Copy Markdown
Author

I just added the missing import, and I'm really looking forward to seeing this PR merged.
Thank help from @anthonypelletier

Comment thread fastapi_crudrouter/core/_utils.py Outdated
Comment thread fastapi_crudrouter/core/_utils.py Outdated
@0x587

0x587 commented Nov 1, 2023

Copy link
Copy Markdown
Author

Okay, I have modified the location of the import. @awtkns

@jofhanen

Copy link
Copy Markdown

This is still an issue, will this patch be updated soon?

@paulocoutinhox

Copy link
Copy Markdown

hi, can you merge?

@0x587

0x587 commented Sep 13, 2024

Copy link
Copy Markdown
Author

Waiting for @awtkns 's approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants