dep: set dompurify minimum to 3.4.11 in package.json#1324
Open
jacobjuul wants to merge 1 commit into
Open
Conversation
Previously only the lockfile was updated, leaving package.json at ^3.2.5. Consumers resolving from the registry would still get a vulnerable version.
There was a problem hiding this comment.
Pull request overview
This PR strengthens the security posture of the npm package by ensuring the published package.json dependency range for dompurify has a minimum of 3.4.11, preventing registry consumers from resolving older (potentially vulnerable) 3.x versions that still satisfied the prior ^3.2.5 range.
Changes:
- Bump the declared
dompurifydependency inpackage.jsonfrom^3.2.5to^3.4.11. - Update
yarn.lockto resolvedompurifyto3.4.11under the new range.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Raises the registry-advertised minimum dompurify version to ^3.4.11. |
| yarn.lock | Updates the locked dompurify resolution to 3.4.11 to match the new dependency range. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous release (v2.1.19) only updated dompurify in the lockfile, leaving
package.jsonat^3.2.5. Consumers resolving from the registry can still end up with a vulnerable version since npm/yarn/pnpm will resolve anything satisfying that range.This bumps the declared minimum to
^3.4.11so the registry-advertised constraint excludes vulnerable versions.Note: Dependabot has an open branch (
dependabot/npm_and_yarn/dompurify-3.4.11) with the same intent but it only updates the lockfile, notpackage.json.