Adds non-mempool wallet balance to overview by ajtowns · Pull Request #911 · bitcoin-core/gui

ajtowns · 2025-11-19T01:26:12Z

The wallet can contain transactions that are not accepted into the node's mempool (eg due to containing a too large OP_RETURN output, due to too low a feerate, or due to too many unconfirmed ancestors). In the event you end up in this situation, it can appear as if funds have gone missing from your wallet due to the non-mempool balance not being reported. Correct this by reporting the non-mempool balance.

See bitcoin/bitcoin#33671 for further context.

DrahtBot · 2025-11-19T01:26:26Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept ACK	pablomartin4btc, polespinasa

If your review is incorrectly listed, please copy-paste  into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#bitcoin/bitcoin/35511 (RFC: consensus: Make CAmount a class by hodlinator)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

ajtowns · 2025-11-19T07:06:47Z

To test, start with -datacarriersize=10, and run

send '{"data": "4368616e63656c6c6f72206f6e206272696e6b206f66207365636f6e64206261696c6f757420666f722062616e6b73"}' null "unset" 1

from the console. "Non-mempool: " should appear in the Balances pane on the Overview window with the change from the transaction. Restarting with -datacarriersize=100000 should allow the tx to enter the mempool, and move the amount into the Available balance. (Presumably, do this on -regtest after generating 100 blocks; or perhaps signet after grabbing some funds from a faucet)

ajtowns · 2025-11-27T08:03:31Z

Screenshot:

The negative sign for the non-memool stuff isn't really very clear, perhaps.

ajtowns · 2026-04-23T02:41:50Z

Rebased after merge of parent PR, should be ready to review. Happy to close if some someone wants to take over.

polespinasa · 2026-06-01T14:33:04Z

Maybe I'm not understanding the issue, but does this matter?
If that is a transaction we created we will not broadcast it.
If that is a transaction we are receiving we will not be able to spend the outputs until it is confirmed as the child will be rejected by our mempool.

So I am not really getting the issue, we just need to wait for it to be confirmed.

IIUC this only makes sense for private-broadcast.

ajtowns · 2026-06-01T17:07:36Z

Worst case, I guess: if you make a transaction that doesn't hit the mempool, it won't be visible in your balance, which may lead you to try to make the same transaction again. That might happen if the first transaction was spending some unconfirmed outputs from large transactions, so your new transaction would have exceeded the cluster size limits. Once those large transactions confirm, your nonmempool transaction will be broadcast and able to be confirmed.

pablomartin4btc

Concept ACK

The negative sign for the non-mempool stuff isn't really very clear, perhaps.

I think for negative amounts we use COLOR_NEGATIVE - defined in guiconstants.h (at least for transactions).

Thinking out loud... shouldn't be the non-mempool balance shown under the pending one like a subitem...

polespinasa · 2026-06-22T14:04:04Z

Worst case, I guess: if you make a transaction that doesn't hit the mempool, it won't be visible in your balance, which may lead you to try to make the same transaction again. That might happen if the first transaction was spending some unconfirmed outputs from large transactions, so your new transaction would have exceeded the cluster size limits. Once those large transactions confirm, your nonmempool transaction will be broadcast and able to be confirmed.

I see, didn't check the code when asking, had the same concerns as here bitcoin/bitcoin#33671 (comment), but I saw the approach taken there was pretty nice tbh.

Concept ACK

polespinasa · 2026-06-22T14:25:39Z

The negative sign for the non-memool stuff isn't really very clear, perhaps.

It is not :)

I don't think we show in the balance overview the "negative" (outgoing) balance, we just reduce the available amount.

polespinasa · 2026-06-22T14:31:14Z

+            <item row="3" column="0">
+             <widget class="QLabel" name="labelNonMempoolText">
+              <property name="text">
+               <string>Non-mempool:</string>


just a silly feel-free-to-ignore nit: in the rpc we use nonmempool no non_mempool. Maybe we don't want to use the - for consistency?

Also maybe mempool can be tooo techincal for some users? What about Pending (unbroadcast) or something similar?

I was thinking the same and have expressed it in my previous comment but I've checked in the code and it seems that unbroadcast has a different meaning I think (transactions that ARE in the mempool but haven't been relayed to peers yet - m_unbroadcast_txids in txmempool.h), and for the pending section, there's a key difference: Pending = mempool → almost certain to confirm soon; Non-mempool = might never confirm, so it would be also misleading.

Maybe non-standard and then add a ? icon next to it, if putting the mouse on top it shows a small explanation? IIRC we used that ? in the past for some rbf comments.

The label has a tooltip already, I left a suggestion there.

polespinasa · 2026-06-22T17:26:13Z


 QString BitcoinUnits::formatWithPrivacy(Unit unit, const CAmount& amount, SeparatorStyle separators, bool privacy)
 {
-    assert(amount >= 0);


nit: Maybe this change motivation should be documented in the commit message. It is not clear why is needed.
Just a simple line saying that m_mine_nonmempool is always negative so this assert is no longer true should be enough.

polespinasa · 2026-06-22T17:27:14Z

    ui->labelImmatureText->setVisible(showImmature);
+
+    // likewise for non-mempool balances
+    bool showNonMempool = balances.nonmempool_balance != 0;


maybe < 0 ?

polespinasa · 2026-06-22T17:30:28Z

    // Update walletModel cached balance which will trigger an update for the 'labelBalance' QLabel.
    walletModel.pollBalanceChanged();
    // Check balance in send dialog
    CompareBalance(walletModel, walletModel.wallet().getBalance(), sendCoinsDialog.findChild<QLabel*>("labelBalance"));


Maybe we can use this PR to update this to also use:
walletModel.wallet().getBalances().balance

Like you did below?

pablomartin4btc

@ajtowns, I've added a test that perhaps you may want to include here, it checks the label visibility and its value, please check e746d9e (based on top of your changes).

I think this PR should include a doc/release-notes-911.md file. Suggested text:

GUI Changes
-----------
  - The Overview page now displays a "Non-mempool:" balance row showing funds that would be spent if wallet transactions currently outside the mempool were to confirm. This row is only shown when non-mempool wallet transactions are present.

pablomartin4btc · 2026-06-25T03:09:50Z

+               <cursorShape>IBeamCursor</cursorShape>
+              </property>
+              <property name="toolTip">
+               <string>Balance for wallet transactions not in the mempool</string>


nit: I think the tooltip text doesn't tell the user what that means in practice, or why it's negative...

Suggested change

<string>Balance for wallet transactions not in the mempool</string>

<string>Balance about to be spent by wallet transactions not currently in the mempool. May never confirm.</string>

pablomartin4btc · 2026-06-25T03:24:28Z

+            <item row="3" column="0">
+             <widget class="QLabel" name="labelNonMempoolText">
+              <property name="text">
+               <string>Non-mempool:</string>


I was thinking the same and have expressed it in my previous comment but I've checked in the code and it seems that unbroadcast has a different meaning I think (transactions that ARE in the mempool but haven't been relayed to peers yet - m_unbroadcast_txids in txmempool.h), and for the pending section, there's a key difference: Pending = mempool → almost certain to confirm soon; Non-mempool = might never confirm, so it would be also misleading.

pablomartin4btc · 2026-06-25T03:52:40Z

    ui->labelImmature->setText(BitcoinUnits::formatWithPrivacy(unit, balances.immature_balance, BitcoinUnits::SeparatorStyle::ALWAYS, m_privacy));
-    ui->labelTotal->setText(BitcoinUnits::formatWithPrivacy(unit, balances.balance + balances.unconfirmed_balance + balances.immature_balance, BitcoinUnits::SeparatorStyle::ALWAYS, m_privacy));
+    ui->labelNonMempool->setText(BitcoinUnits::formatWithPrivacy(unit, balances.nonmempool_balance, BitcoinUnits::SeparatorStyle::ALWAYS, m_privacy));
+    ui->labelTotal->setText(BitcoinUnits::formatWithPrivacy(unit, balances.balance + balances.unconfirmed_balance + balances.immature_balance + balances.nonmempool_balance, BitcoinUnits::SeparatorStyle::ALWAYS, m_privacy));


nit: the non-mempool balance is currently a plain text with no visual emphasis, perhaps since it's always negative, it should be red (like negative amounts in the transaction list)... (haven't tested it)

Suggested change

ui->labelTotal->setText(BitcoinUnits::formatWithPrivacy(unit, balances.balance + balances.unconfirmed_balance + balances.immature_balance + balances.nonmempool_balance, BitcoinUnits::SeparatorStyle::ALWAYS, m_privacy));

ui->labelNonMempool->setStyleSheet("QLabel { color: " + COLOR_NEGATIVE.name() + "; }");

ui->labelTotal->setText(BitcoinUnits::formatWithPrivacy(unit, balances.balance + balances.unconfirmed_balance + balances.immature_balance + balances.nonmempool_balance, BitcoinUnits::SeparatorStyle::ALWAYS, m_privacy));

ajtowns mentioned this pull request Nov 19, 2025

wallet: Add separate balance info for non-mempool wallet txs bitcoin/bitcoin#33671

Merged

DrahtBot added the CI failed label Nov 19, 2025

This was referenced Nov 21, 2025

rpc: require integer verbosity; remove boolean 'verbose' bitcoin/bitcoin#33214

Closed

wallet: Track no-longer-spendable TXOs separately bitcoin/bitcoin#27865

Open

ajtowns force-pushed the 202511-wallet-unconf-bal-gui branch from 029dc0d to 4be5d3d Compare November 27, 2025 08:02

ajtowns force-pushed the 202511-wallet-unconf-bal-gui branch from 4be5d3d to bc85b4a Compare November 27, 2025 08:30

DrahtBot mentioned this pull request Nov 30, 2025

wallet, rpc: add UTXO set check and incremental rescan to importdescriptors bitcoin/bitcoin#33392

Open

DrahtBot mentioned this pull request Jan 25, 2026

test: rename assert_greater_than(_or_equal) to assert_gt/assert_ge bitcoin/bitcoin#34395

Closed

DrahtBot mentioned this pull request Feb 12, 2026

wallet: Disallow wallet names that are paths including .. and . elements bitcoin/bitcoin#34544

Merged

DrahtBot mentioned this pull request Mar 26, 2026

wallet: mark bip125-replaceable RPC key and walletrbf startup option as deprecated bitcoin/bitcoin#34917

Merged

gui: Add non-mempool balance to wallet overview

026088b

ajtowns force-pushed the 202511-wallet-unconf-bal-gui branch from bc85b4a to 026088b Compare April 23, 2026 02:32

ajtowns marked this pull request as ready for review April 23, 2026 02:33

vasild mentioned this pull request Apr 24, 2026

Private broadcast tracking bitcoin/bitcoin#34476

Open

26 tasks

ajtowns closed this Jun 1, 2026

ajtowns reopened this Jun 1, 2026

DrahtBot removed the CI failed label Jun 1, 2026

DrahtBot mentioned this pull request Jun 12, 2026

RFC: consensus: Make CAmount a class bitcoin/bitcoin#35511

Open

pablomartin4btc mentioned this pull request Jun 20, 2026

Wallet Missing Balances/Unspent bitcoin/bitcoin#28797

Open

1 task

pablomartin4btc reviewed Jun 20, 2026

View reviewed changes

polespinasa reviewed Jun 22, 2026

View reviewed changes

pablomartin4btc reviewed Jun 25, 2026

View reviewed changes

	<string>Balance for wallet transactions not in the mempool</string>
	<string>Balance about to be spent by wallet transactions not currently in the mempool. May never confirm.</string>

	ui->labelTotal->setText(BitcoinUnits::formatWithPrivacy(unit, balances.balance + balances.unconfirmed_balance + balances.immature_balance + balances.nonmempool_balance, BitcoinUnits::SeparatorStyle::ALWAYS, m_privacy));
	ui->labelNonMempool->setStyleSheet("QLabel { color: " + COLOR_NEGATIVE.name() + "; }");
	ui->labelTotal->setText(BitcoinUnits::formatWithPrivacy(unit, balances.balance + balances.unconfirmed_balance + balances.immature_balance + balances.nonmempool_balance, BitcoinUnits::SeparatorStyle::ALWAYS, m_privacy));

Uh oh!

Conversation

ajtowns commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews

Conflicts

Uh oh!

ajtowns commented Nov 19, 2025

Uh oh!

ajtowns commented Nov 27, 2025

Uh oh!

ajtowns commented Apr 23, 2026

Uh oh!

polespinasa commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ajtowns commented Jun 1, 2026

Uh oh!

pablomartin4btc left a comment

Choose a reason for hiding this comment

Uh oh!

polespinasa commented Jun 22, 2026

Uh oh!

polespinasa commented Jun 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pablomartin4btc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pablomartin4btc Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ajtowns commented Nov 19, 2025 •

edited

Loading

DrahtBot commented Nov 19, 2025 •

edited

Loading

polespinasa commented Jun 1, 2026 •

edited

Loading

pablomartin4btc Jun 25, 2026 •

edited

Loading