gui: show wallet name in progress messages#939
Open
ShauryaaSharma wants to merge 1 commit into
Open
Conversation
Include the wallet display name in initMessage calls for "Loading wallet...", "Creating wallet...", and "Rescanning..." so the splash screen clearly identifies which wallet is being processed at startup. For unnamed (default) wallets, DisplayName() returns the translated "default wallet" string. Add a comment to LoadWalletsActivity::load() noting that no wallet name is shown there because multiple wallets may be loading simultaneously. Fixes bitcoin-core#259
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Include the wallet display name in the
initMessagecalls made duringwallet loading so the splash screen clearly identifies which wallet is
being processed:
LoadWalletInternal:"Loading wallet…"→"[wallet_name] Loading wallet…"CreateWallet:"Creating wallet…"→"[wallet_name] Creating wallet…"CWallet::AttachChain:"Rescanning…"→"[wallet_name] Rescanning…"(primary fix)For unnamed (default) wallets,
DisplayName()already returns thetranslated
"default wallet"string, handling that case correctly.A comment is added to
LoadWalletsActivity::load()explaining why nospecific wallet name is shown there — it loads multiple wallets
simultaneously from the node's wallet list.
Why
When a wallet that has not been synchronized recently is opened — either
via
settings.jsonat startup or via File > Open Wallet — the splashscreen shows a bare
"Rescanning…"with no indication of which walletis being scanned. Users with multiple wallets have no way to know which
one is being processed without checking the debug log.
The
ShowProgresscalls insideScanForWalletTransactionsalready use"[wallet_name] Rescanning…"(lines 1888/1903/2008); this change makesthe preceding
initMessageconsistent with them.Fixes #259