qt: warn about rescan in wallet migration dialogs#943
Open
ShauryaaSharma wants to merge 1 commit into
Open
Conversation
Migrating a legacy wallet triggers a blockchain rescan immediately after conversion. Depending on the chain size and whether -blockfilterindex is active, this rescan can take anywhere from minutes to hours, with no visual indication that anything is happening. Add a rescan warning to the informative text of both migration confirmation dialogs (migrate and restore-and-migrate) so users can plan accordingly before clicking Confirm. Also update the progress dialog label in do_migrate() to state that a blockchain rescan will follow migration, giving users context while the operation runs. Fixes bitcoin-core#930
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #930.
Migrating a legacy wallet triggers an automatic blockchain rescan
immediately after the conversion completes. Depending on chain size
and whether
-blockfilterindexis enabled, this rescan can takeanywhere from minutes to hours. During this time the progress dialog
shows "Migrating Wallet…" with no indication that a rescan is
happening — only the debug log reveals what is going on.
Fix
Three changes, all in
MigrateWalletActivity:1 & 2 — Confirmation dialogs (
migrate()andrestore_and_migrate()): append a rescan warning to the informativetext so users know what to expect before clicking Confirm:
3 — Progress dialog (
do_migrate()): update the label from thebare "Migrating Wallet…" to also mention the rescan, so users who are
already in the waiting phase have context:
Notes
src/qt/walletcontroller.cpp.text.
migrateWallet()as a singleblocking call; separating migration from rescan would require wallet
backend changes and is out of scope here.