Conversation
Find degrees of freedom for `non_central_f` distribution
The degree of freedom finders can call the quantile with arguments which result in an infinite result, as far as our root finders are concerned, any large value as a result will do, but we need to not allow an exception to escape or the root finder terminates.
* Guard against intermediate x*x overflow in Student's t pdf/cdf * Return exact tail values instead of raising overflow_error (review feedback) --------- Co-authored-by: LeantionX <leontyevanton1995@gmail.com> Co-authored-by: Matt Borland <matt@mattborland.com>
…ial_guess ENH: add warm start for root finder in `find_degrees_of_freedom`
Make sure we throw the correct exceptions when the result is infinite. Fixes #1404.
DOC: Include the use of the bootstrap script to build b2 in README.md
pFq: prevent spurious overflow.
<sstream> is not needed in exception free environment
Member
Author
|
Strangely the macOS runs are starting to fail consistently with: It's been >4 years since the last commit to the cubic roots code? |
Member
Author
|
Mac failures are fixed in #1417, so I will wait for that to be merged so that it can automatically be populated into master |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1415 +/- ##
==========================================
+ Coverage 95.34% 95.39% +0.05%
==========================================
Files 825 828 +3
Lines 68160 68931 +771
==========================================
+ Hits 64986 65759 +773
+ Misses 3174 3172 -2
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Check all of special functions can be included under same conditions
Fix UB in sorting results with the cubic root finder
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deadline is today, kind of slipped my mind