-
Notifications
You must be signed in to change notification settings - Fork 254
feat: make cloud provider packages optional #298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
73ae141
4b1a60c
99f5f26
a8d8df1
85d970e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,23 @@ | ||||||||||||||||||||||
| import { describe, it, expect, vi, beforeEach } from 'vitest'; | ||||||||||||||||||||||
| import { isDriverNotInstalled } from '../module-loader.js'; | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| describe('generateRdsAuthToken missing package', () => { | ||||||||||||||||||||||
| it('should throw actionable error when @aws-sdk/rds-signer is not installed', async () => { | ||||||||||||||||||||||
|
||||||||||||||||||||||
| import { describe, it, expect, vi, beforeEach } from 'vitest'; | |
| import { isDriverNotInstalled } from '../module-loader.js'; | |
| describe('generateRdsAuthToken missing package', () => { | |
| it('should throw actionable error when @aws-sdk/rds-signer is not installed', async () => { | |
| import { describe, it, expect } from 'vitest'; | |
| import { isDriverNotInstalled } from '../module-loader.js'; | |
| describe('generateRdsAuthToken missing package', () => { | |
| it('should throw actionable error when @aws-sdk/rds-signer is not installed', () => { |
Copilot
AI
Apr 2, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suite name suggests it’s validating generateRdsAuthToken behavior when @aws-sdk/rds-signer is missing, but the assertions only test isDriverNotInstalled(). This leaves the new user-facing error path in generateRdsAuthToken() untested. Consider either renaming the suite to match what’s tested or adding a test that forces the dynamic import("@aws-sdk/rds-signer") to fail and asserts the thrown install message.
Uh oh!
There was an error while loading. Please reload this page.