[cli] Fix multipass find column widths: narrow Image, widen Aliases#5091
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5091 +/- ##
=======================================
Coverage 73.13% 73.13%
=======================================
Files 331 331
Lines 17720 17720
=======================================
Hits 12958 12958
Misses 4762 4762 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Move some space from the "Image" to the "Aliases" column. The latter was overflowing and the former does not need as much since appliances and blueprints are gone. Fixes #5085. Signed-off-by: Ricardo Abreu <ricardo.abreu@canonical.com>
94f6fc4 to
0093020
Compare
There was a problem hiding this comment.
Pull request overview
Adjusts the multipass find table formatter to allocate less fixed width to the Image column and more to Aliases, improving readability for images with many aliases while keeping the overall table width unchanged.
Changes:
- Swapped the fixed column widths for Image and Aliases in the table formatter output.
- Updated unit-test golden files for table formatter output to match the new spacing.
- Updated the primary
multipass findexample output in the CLI reference docs.
Reviewed changes
Copilot reviewed 1 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/client/cli/formatter/table_formatter.cpp | Swaps Image/Aliases column widths in multipass find table output. |
| tests/unit/test_data/formatters/table/find_one_reply.txt | Updates expected header spacing for new column widths. |
| tests/unit/test_data/formatters/table/find_one_reply_no_os.txt | Updates expected header spacing for new column widths. |
| tests/unit/test_data/formatters/table/find_multiple_reply.txt | Updates expected rows/header spacing where aliases are present. |
| tests/unit/test_data/formatters/table/find_multiple_reply_duplicate_image.txt | Updates expected header spacing for new column widths. |
| docs/reference/command-line-interface/find.md | Updates the main multipass find example output to match new formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6e0d214 to
8f1506a
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ricardo Abreu <ricardo.abreu@canonical.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ricardo Abreu <ricardo.abreu@canonical.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 8 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
docs/tutorial/index.md:335
- The PR description says the docs change is limited to
docs/.../find.mdand focuses on column-width redistribution, but this hunk also updates the content of the example output (image list and version numbers). That makes the scope larger than described and can create unnecessary doc churn unless it’s intentional.
Consider either (a) updating the PR description to explicitly call out these broader docs updates, or (b) limiting the docs changes here to spacing-only if the intent is purely column-width formatting.
Image Aliases Version Description
22.04 jammy 20260705 Ubuntu 22.04 LTS
24.04 noble 20260705 Ubuntu 24.04 LTS
26.04 resolute,lts,ubuntu 20260720 Ubuntu 26.04 LTS
daily:26.10 stonking,devel 20260627 Ubuntu 26.10
Description
Redistribute space from the Image column to the Aliases column. The net width remains the same.
Changes:
table_formatter.cpp: Swap widthsBefore:
After:
Related Issue(s)
#5085
MULTI-2785
Testing
Screenshots (if applicable)
Checklist