fix: update CocoaPods dependency constraints in podspec files to allow minor updates - #1006
Merged
Merged
Conversation
robingenz
added
bug/fix
There was a problem hiding this comment.
Pull request overview
This PR aligns the iOS CocoaPods dependency constraints across the project by relaxing Firebase (and related) version requirements in podspecs so consumers can install newer minor versions without waiting for a plugin release.
Changes:
- Relax Firebase podspec constraints from
~> 12.7.0(patch-only) to~> 12.7(allows minor updates up to< 13.0). - Relax
GoogleSignIn/ Facebook SDK pins inCapacitorFirebaseAuthentication.podspecfrom exact versions to~>ranges to match SwiftPM intent. - Update
GoogleSignIninpackages/authentication/ios/Podfileto~> 9.0for consistency with the authentication podspec/SwiftPM.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/storage/CapacitorFirebaseStorage.podspec |
Relax FirebaseStorage constraint to allow minor updates. |
packages/remote-config/CapacitorFirebaseRemoteConfig.podspec |
Relax FirebaseRemoteConfig constraint to allow minor updates. |
packages/performance/CapacitorFirebasePerformance.podspec |
Relax FirebasePerformance constraint to allow minor updates. |
packages/messaging/CapacitorFirebaseMessaging.podspec |
Relax FirebaseMessaging constraint to allow minor updates. |
packages/functions/CapacitorFirebaseFunctions.podspec |
Relax FirebaseFunctions constraint to allow minor updates. |
packages/firestore/CapacitorFirebaseFirestore.podspec |
Relax FirebaseFirestore constraint to allow minor updates. |
packages/crashlytics/CapacitorFirebaseCrashlytics.podspec |
Relax FirebaseCrashlytics constraint to allow minor updates. |
packages/authentication/CapacitorFirebaseAuthentication.podspec |
Relax FirebaseAuth and third-party SDK pins (GoogleSignIn, FBSDK*) to allow minor updates. |
packages/app/CapacitorFirebaseApp.podspec |
Relax FirebaseCore constraint to allow minor updates. |
packages/app-check/CapacitorFirebaseAppCheck.podspec |
Relax FirebaseAppCheck constraint to allow minor updates. |
packages/analytics/CapacitorFirebaseAnalytics.podspec |
Relax Firebase Analytics subspec constraints to allow minor updates. |
packages/authentication/ios/Podfile |
Bump GoogleSignIn pod constraint to ~> 9.0 for alignment with podspec/SwiftPM. |
.changeset/quiet-jokes-attack.md |
Add changeset to publish patch releases for affected packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@capacitor-firebase/analytics
@capacitor-firebase/app
@capacitor-firebase/app-check
@capacitor-firebase/authentication
@capacitor-firebase/crashlytics
@capacitor-firebase/firestore
@capacitor-firebase/functions
@capacitor-firebase/messaging
@capacitor-firebase/performance
@capacitor-firebase/remote-config
@capacitor-firebase/storage
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The podspec files restricted the Firebase dependencies to
~> 12.7.0, which in CocoaPods only permits patch updates (>= 12.7.0, < 12.8.0). As a result, consumers were unable to install newer Firebase releases such as 12.17.0 without waiting for a new plugin release.This was inconsistent with the rest of the project:
*.podspec~> 12.7.0>= 12.7.0, < 12.8.0(patch only)Package.swift.upToNextMajor(from: "12.7.0")>= 12.7.0, < 13.0.0ios/Podfile~> 12.7>= 12.7, < 13.0#910 already relaxed these constraints, but only for the
Podfilefiles. The podspec files were missed and are corrected here.Changes
~> 12.7.0to~> 12.7, so minor updates are allowed.CapacitorFirebaseAuthentication.podspec(GoogleSignIn9.0.0to~> 9.0,FBSDKCoreKitandFBSDKLoginKit18.0.0to~> 18.0) to match the ranges already used inPackage.swift.GoogleSignIninpackages/authentication/ios/Podfilefrom~> 7.1to~> 9.0. It was two major versions behind the podspec andPackage.swift, which both already required 9.0.0.The Firebase version itself is intentionally not bumped. Relaxing the constraint is enough to let consumers install 12.17.0.
Testing
npm run verify:iospasses forpackages/authentication, withGoogleSignInresolving to 9.2.0.Close #1005