Skip to content

Refactor error response handling in proxy plugin #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aswmac wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −2
Open

Refactor error response handling in proxy plugin #1258

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6999eff
Refactor error response handling in proxy plugin
aswmac Jun 13, 2026
aed8d8c
Improve error logging for proxy errors
aswmac Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/plugins/default/error-response-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,17 @@ export const errorResponsePlugin: Plugin = definePlugin((proxyServer, options) =
if (!req || !res) {
throw err; // "Error: Must provide a proper URL as target"
}
// Log full details server-side where only admins can see them
console.error(`Proxy error for ${req.headers.host}${req.url}:`, err);
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

// Return generic error to client
if (isResponseLike(res)) {
if (!res.headersSent) {
const statusCode = getStatusCode((err as unknown as any).code);
res.writeHead(statusCode);
}

const host = req.headers && req.headers.host;
res.end(`Error occurred while trying to proxy: ${sanitize(host)}${sanitize(req.url)}`);
res.end('UPSTREAM_ERROR');
} else if (isSocketLike(res)) {
res.destroy();
}
Expand Down