Fix LocalClient#delete_all_in_path not using partitioned key#5237
Merged
johha merged 1 commit intoJun 26, 2026
Merged
Conversation
WeiQuan0605
force-pushed
the
fix-local-client-delete-all-in-path
branch
from
879e4a5 to
bc32cd6
Compare
delete_all_in_path was building the path with the raw key instead of partitioned_key, so it looked in the wrong directory and deleted nothing. All other LocalClient methods use partitioned_key consistently.
WeiQuan0605
force-pushed
the
fix-local-client-delete-all-in-path
branch
from
bc32cd6 to
badf724
Compare
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jun 26, 2026
Changes in cloud_controller_ng:
- Fix LocalClient#delete_all_in_path not using partitioned key
PR: cloudfoundry/cloud_controller_ng#5237
Author: Wei Quan <64415962+WeiQuan0605@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalClient#delete_all_in_pathwas building the target path with the raw key instead ofpartitioned_key(key), so it looked in the wrong directory and silently deleted nothing.All other
LocalClientmethods (exists?,cp_to_blobstore,file_path, etc.) usepartitioned_keyconsistently, which maps a key likeabcdef1234toab/cd/abcdef1234.delete_all_in_pathwas the only method missing this, making it a no-op in practice.lib/cloud_controller/blobstore/local/local_client.rb: usepartitioned_key(path)indelete_all_in_pathspec/unit/lib/cloud_controller/blobstore/local/local_client_spec.rb: rewrite the test using real blobstore keys so the partitioned path is actually exercised (the old test used raw directory names and did not catch the bug)I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests